Update MimeType map to include .jfif extension#631
Open
pawelabrams wants to merge 1 commit intoguzzle:2.8from
Open
Update MimeType map to include .jfif extension#631pawelabrams wants to merge 1 commit intoguzzle:2.8from
pawelabrams wants to merge 1 commit intoguzzle:2.8from
Conversation
Add jfif extension, used by Windows 10 and 11 as a default extension of image/jpeg MIME type.
Author
|
Should I add a test case for it to tests/MimeTypeTest.php? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add jfif extension, used by Windows 10 and 11 as a default extension of image/jpeg MIME type.
Several topics about users complaining about this:
At a project of mine, we currently face a problem with that as users will email/send a picture of a document to themselves via WhatsApp – and while they can upload it and system will recognize it as image/jpeg just fine, we cannot use Guzzle to send it to an external service without specifying MIME type manually (it will send it as application/octet-stream by default).
I recognize it may be classified as my project's issue, but the issue is so pervasive that I think others may have found themselves scratching their heads as well.
Other projects that recognize .jfif as image/jpeg: