Use popover from guardian source components - #8116
Open
maloky wants to merge 4 commits into
Open
Conversation
Contributor
Contributor
|
Size Change: -20.2 kB (-1.12%) Total Size: 1.78 MB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
rupertbates
reviewed
Jul 23, 2026
| SvgTickRound, | ||
| } from '@guardian/source/react-components'; | ||
| import Tooltip from 'components/tooltip/Tooltip'; | ||
| import { useWindowWidth } from 'pages/aus-moment-map/hooks/useWindowWidth'; |
Member
There was a problem hiding this comment.
Not for this PR necessarily but I wonder whether this should live somewhere other than the Australia moment map?
Contributor
Author
There was a problem hiding this comment.
had the exact same thought. it should totally move out of there 👍
| {promptText && <p css={copy}>{promptText}</p>} | ||
| <div css={buttonAndTooltipContainer}> | ||
| <div> | ||
| <div css={popoverStyles}> |
Contributor
There was a problem hiding this comment.
Perhaps we could set the background colour here? ie to stop this white on blue effect ->
| )} | ||
| <div css={[checkListTextCss, item.maybeGreyedOut]}> | ||
| {typeof item.text === 'string' ? ( | ||
| <span css={checkListTextItemCss}> |
Contributor
There was a problem hiding this comment.
can we remove associated styling checkListTextItemCss from this file too?
| placement="bottom" | ||
| desktopOnly={true} | ||
| ></Tooltip> | ||
| {item.toolTip && windowWidthIsGreaterThan('desktop') && ( |
paul-daniel-dempsey
approved these changes
Jul 23, 2026
paul-daniel-dempsey
left a comment
paul-daniel-dempsey
left a comment
Contributor
There was a problem hiding this comment.
Great work, ooks much simpler with this component.
Thinks there are a few visual colours diffs and possibly some minor cropping diffs too (see below) - all take or leave tbh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you doing in this PR?
Replace usage of floating-ui tooltip in favor of guardian Popover source component.
Only available on screens from desktop.
Asana Card
Why are you doing this?
floating-ui tooltip had some accessibility issues that are solved in the newly guardian Popover. On top of that we drop a external dependency.
How to test
Screenshots