fix: desktop heading margin unaffected by AB test variant - #2665
Merged
DanielCliftonGuardian merged 2 commits intoAug 17, 2026
Merged
Conversation
|
dskamiotis
changed the title
Contributor
Contributor
|
Size Change: 0 B Total Size: 262 kB ℹ️ View Unchanged
|
DanielCliftonGuardian
approved these changes
Aug 17, 2026
DanielCliftonGuardian
deleted the
ds/fix-spacefinder-highvalue-desktop-heading-margin
branch
August 17, 2026 09:41
|
Seen on PROD (created by @dskamiotis and merged by @DanielCliftonGuardian 1 minute and 50 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds
isInOriginalHighValueSectionto ensure the desktop desktopInline1 heading marginTop (0 vs 190px) remains tied to the original 10 highValueSections only, and is not affected by the 5 new sections added behind the AB test variant.Why?
The previous PR added the 5 new sections to highValueSections but didn't account for the desktop heading margin side effect (ticket scope point 5/6). This fix ensures the AB test only affects mobile ad spacing, as intended.