Fix Wikitext (Zim wiki) multiline code block rendering#2808
Open
Self-Perfection wants to merge 1 commit intogsantner:masterfrom
Open
Fix Wikitext (Zim wiki) multiline code block rendering#2808Self-Perfection wants to merge 1 commit intogsantner:masterfrom
Self-Perfection wants to merge 1 commit intogsantner:masterfrom
Conversation
Extract `{{{code: ...}}}` (Zim Source View plugin) and `'''...'''`
(Zim standard preformatted) blocks before the per-line transformation
so their content is not mangled by inline rules like IMAGE
(`{{X}}` -> image embed). Extracted blocks are wrapped in Markdown
fenced code blocks and re-inserted after the per-line pass.
Fixes: multiline code blocks containing `{{Variable}}` tokens being
rendered as broken images and live HTML.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Author
|
Tested APK with this file Works as expected! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract
{{{code: ...}}}(Zim Source View plugin) and'''...'''(Zim standard preformatted) blocks before the per-line transformation so their content is not mangled by inline rules like IMAGE ({{X}}-> image embed). Extracted blocks are wrapped in Markdown fenced code blocks and re-inserted after the per-line pass.Fixes: multiline code blocks containing
{{Variable}}tokens being rendered as broken images and live HTML.Tested by running added code in Java, separately from Markor. Relying on CI/CD in your repo for building APK for full integration test.
I've seen request to do auto-reformat. But I do not have Android studio. And for me generated code looks OKish? I suppose Claude is good enough in following conventions and this does not need passing through external tools for proper formatting?