Add support for static cursor#2807
Open
guanglinn wants to merge 4 commits intogsantner:masterfrom
Open
Conversation
harshad1
reviewed
Apr 24, 2026
| /** | ||
| * Static cursor drawer for EditText. | ||
| */ | ||
| static class StaticCursorDrawer { |
Collaborator
There was a problem hiding this comment.
General note for the future:
One of the annoying things in todo.txt is that increasing the line spacing also grows the cursor height for the first and last visual line per item. If we are going to draw the cursor, we can manually force the cursor height to be consistent
Contributor
Author
There was a problem hiding this comment.
Yes, it can solve that problem in todo.txt
This is before
This is now, enabled static cursor
Collaborator
There was a problem hiding this comment.
This is very nice! Thank you!
harshad1
previously approved these changes
Apr 24, 2026
Contributor
Author
|
Screen recording SVID_20260425_055243_1.mp4 |
…cked when the static cursor is enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implemented "static cursor" for feature requests #2525 #2790 #2792