kandji2snipe 1.1.0#35
Open
briangoldstein wants to merge 5 commits into
Open
Conversation
Kandji Device Activity API Pagination - Added pagination to the get_kandji_device_activity_date() function - Calculates offset to jump directly to the last page instead of iterating through all pages - Added error handling for missing activity data (shouldn’t happen, but good to validate) Improved Logging Messages and Consistency - Added more clarity and consistency (still has room for improvement) - Fixed typos and incorrect labels in logs Improved Record Update Logic - Makes a distinction between a Kandji record’s timestamp being newer vs there being new data to sync from Kandji Asset Tag Sync Validation - Checks the Kandji response when updating the asset tag field, rather than assuming success - Logging is more verbose Checkout/Checkin Logic - Consolidated logic and cleaned up redundant logging - Added confirmation of success
adding user agent change (PR 29/33) to my update
**Kandji Device Activity API Pagination** - Added pagination to the get_kandji_device_activity_date() function - Calculates offset to jump directly to the last page instead of iterating through all pages - Added error handling for missing activity data (shouldn’t happen, but good to validate) - Reported by @Jan-Dovetail [Issue 30](#30) **Improved Logging Messages and Consistency** - Added more clarity and consistency (still has room for improvement) - Fixed typos and incorrect labels in logs **Improved Record Update Logic** - Makes a distinction between a Kandji record’s timestamp being newer vs there being new data to sync from Kandji **Asset Tag Sync Validation** - Checks the Kandji response when updating the asset tag field, rather than assuming success - Logging is more verbose **Checkout/Checkin Logic** - Consolidated logic and cleaned up redundant logging - Added confirmation of success
Merge pull request #33 from grokability/develop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kandji Device Activity API Pagination
Improved Logging Messages and Consistency
Improved Record Update Logic
Asset Tag Sync Validation
Checkout/Checkin Logic