Skip to content

Adding test for issue 1191#1250

Open
shreyas02 wants to merge 1 commit intogridap:issue_1191from
shreyas02:issue-1191
Open

Adding test for issue 1191#1250
shreyas02 wants to merge 1 commit intogridap:issue_1191from
shreyas02:issue-1191

Conversation

@shreyas02
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings March 12, 2026 13:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a regression test for issue #1191, testing that dot-product operations between FE bases from different sub-domains can be evaluated without errors.

Changes:

  • Added test/GridapTests/issues/issue_1191.jl with tests for cross-domain FE basis operations
  • Registered the new test in test/GridapTests/runtests.jl

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/GridapTests/issues/issue_1191.jl New regression test for issue 1191
test/GridapTests/runtests.jl Registers the new test

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.31%. Comparing base (c77b443) to head (fb6c417).
⚠️ Report is 711 commits behind head on issue_1191.

Additional details and impacted files
@@              Coverage Diff               @@
##           issue_1191    #1250      +/-   ##
==============================================
- Coverage       89.60%   89.31%   -0.29%     
==============================================
  Files             213      212       -1     
  Lines           28571    27013    -1558     
==============================================
- Hits            25602    24128    -1474     
+ Misses           2969     2885      -84     
Flag Coverage Δ
drivers 0.00% <ø> (ø)
extensions 0.00% <ø> (ø)
tests 89.32% <ø> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants