Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the k6-operator Runner Job command-line tags to reduce metric cardinality by removing the per-segment job_name tag and replacing it with a stable testrun_name tag derived from the TestRun CR name (without the instance index), aligning with #609.
Changes:
- Replace
--tag job_name=<testrun>-<index>with--tag testrun_name=<testrun>in Runner Job command generation. - Update Runner Job unit tests to assert the new
testrun_nametag across all command variants (quiet/noisy, paused/unpaused, Istio scuttle, cloud output, LocalFile wrapper, segmentation, PLZ).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/resources/jobs/runner.go | Switches the generated k6 metric tag from job_name to testrun_name while keeping instance_id. |
| pkg/resources/jobs/runner_test.go | Updates expected Job command arrays/strings to validate testrun_name instead of job_name. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yorugac
approved these changes
Apr 28, 2026
Collaborator
yorugac
left a comment
yorugac
left a comment
There was a problem hiding this comment.
🙌 Thank you, @federicotdn!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #609.
Remove the
job_nametag in test run Jobs, and add a newtestrun_nametag that only contains the name without instance ID.