fix: don't run starter job if TestRun/K6 is paused#458
Open
LCaparelli wants to merge 1 commit intografana:mainfrom
Open
fix: don't run starter job if TestRun/K6 is paused#458LCaparelli wants to merge 1 commit intografana:mainfrom
LCaparelli wants to merge 1 commit intografana:mainfrom
Conversation
|
|
LCaparelli
commented
Aug 29, 2024
Comment on lines
+96
to
+103
| func (k6 TestRunSpec) isPaused() bool { | ||
| if k6.Paused == "" { | ||
| return true | ||
| } | ||
|
|
||
| paused, _ := strconv.ParseBool(k6.Paused) | ||
| return paused | ||
| } |
Author
There was a problem hiding this comment.
There is a weird behavior here, where if the string passed by the user in is not a valid boolean, it's interpreted as false by ParseBool. I'm just copying the existing behavior from where I extracted this logic, but let me know if we should instead return true, our default if uninformed.
I'd argue validation should be placed elsewhere, perhaps as an enum, but I think it'd be best to just make this a bool and avoid all of these shenanigans #455 :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #457