This repository was archived by the owner on Dec 3, 2025. It is now read-only.
Add spring-boot sample application - #746
Open
ramsrib wants to merge 2 commits into
Open
Conversation
JLLeitschuh
reviewed
Mar 9, 2018
|
|
||
| @Test | ||
| fun hello() { | ||
| Assertions.assertEquals("Hello, Spring Boot!..", restTemplate.getForObject<String>("/hello")) |
Contributor
There was a problem hiding this comment.
⭕ Static import of Assertions.assertEquals probably better.
breskeby
reviewed
Mar 11, 2018
| } | ||
| } | ||
|
|
||
| (tasks.findByName("test") as Test).useJUnitPlatform() |
Contributor
There was a problem hiding this comment.
personally I find
tasks.withType(Test::class.java) {
useJUnitPlatform()
}
more idiomatic
Contributor
There was a problem hiding this comment.
@breskeby
This is simpler:
tasks.withType<Test> {
useJUnitPlatform()
}But this is bikeshedding. The way it is here also makes sense.
Author
|
Build is failing in JDK 8. Any idea? |
ramsrib
force-pushed
the
develop
branch
3 times, most recently
from
April 30, 2018 20:54
5a076eb to
ef63e06
Compare
Contributor
|
@ramsrib Is that a test failure? |
Author
|
It doesn't look like a test failure. |
Signed-off-by: Sriram <sri.kmb@gmail.com>
Signed-off-by: Sriram <sri.kmb@gmail.com>
Author
|
Guys, Any idea on why the build is failing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Added spring-boot sample which is missing in the present kotlin-dsl samples.
Contributor Checklist
developbranch./gradlew check --parallel