Merged
Conversation
ngc92
force-pushed
the
ngc92/pytorch-runner
branch
5 times, most recently
from
dc26e38 to
1271b72
Compare
ngc92
force-pushed
the
ngc92/pytorch-runner
branch
from
1271b72 to
6d030d0
Compare
alexzhang13
approved these changes
Jan 14, 2025
Collaborator
alexzhang13
left a comment
alexzhang13
left a comment
There was a problem hiding this comment.
All working and tested locally. Thanks!
ngc92
force-pushed
the
ngc92/pytorch-runner
branch
from
021d0a0 to
348e36c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the python interface to match the recent cuda changes.
Turns out
run_cuda_programactually doesn't do anything cuda specific, so we can instead reuse this piece of code.In the current state, standalone python (and also cuda, I think) scripts are somewhat broken, as they never use the special pipe to communicate their success status, so these runs will now always be considered failed.