First PR - Michelle Yu - #3
Open
cathuanmic wants to merge 7 commits into
Open
Conversation
| <div class="fullwrap"> | ||
| <img src="weathering with you.jpg" alt="Weathering With You" width="500" height="700"> | ||
| <div class="fullcap"> | ||
| Weathering With You<br><br>Pure delight and tearfully gorgeous<br><br>This story follows a runaway teenaged boy who meets a sunshine girl in Tokyo. It dwells on the theory of fate, where one meets his other half through supernatural means and grit. This is the film's main theme, where the environment is used to appeal than solidify as a breathtaking experience for most audiences. Although instilled with fantasy and Shinto mythology, there is still a hint of reality. References of global warming, child protective services, and struggles in a capitalist society are woven in masterfully.<br><br>Weathering with You is a beautifully animated film about young, spontaneous love that transcends mother nature. 8.5/10 |
Collaborator
There was a problem hiding this comment.
You can put the
tags on another line and move the following text on another line.
|
|
||
| </div> | ||
|
|
||
| <div style="position: relative; width: 100%; height: 0; padding-top: 33.3333%; padding-bottom: 48px; box-shadow: 0 2px 8px 0 rgba(63,69,81,0.16); margin-top: 1.6em; margin-bottom: 0.9em; overflow: hidden; border-radius: 8px; will-change: transform;"> <iframe loading="lazy" style="position: absolute; width: 100%; height: 100%; top: 0; left: 0; border: none; padding: 0;margin: 0;" src="https://www.canva.com/design/DAFHccWRBk4/view?embed" allowfullscreen="allowfullscreen" allow="fullscreen"> </iframe></div><a href="https://www.canva.com/design/DAFHccWRBk4/view?utm_content=DAFHccWRBk4&utm_campaign=designshare&utm_medium=embeds&utm_source=link" target="_blank" rel="noopener"></a> |
Collaborator
There was a problem hiding this comment.
Remove enter spaces between tags.
| position: relative; | ||
| text-align: center; | ||
| width: 75%; | ||
| padding: 20px; |
| p { | ||
| letter-spacing: 2px; | ||
| color: #67595E; | ||
| /*border-bottom: 1px dashed #777;*/ |
Collaborator
There was a problem hiding this comment.
Remove commented code before pushing at all times. :)
| color: white; | ||
| } | ||
|
|
||
| /* (D) SHOW/HIDE */ |
| <link rel="javascript" href="script.js"> | ||
| <link href='https://fonts.google.com/specimen/Ubuntu#standard-styles' rel='stylesheet'> | ||
| <link rel="stylesheet" href="https://stackpath.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css"> | ||
| </head> |
Collaborator
There was a problem hiding this comment.
Remove this spacing between tags.
mirandasong24
requested changes
Aug 7, 2022
mirandasong24
left a comment
mirandasong24
left a comment
Collaborator
There was a problem hiding this comment.
Good job overall, just some formatting of code you need to fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.