refactor(web): extract web host runtime and streamline exports#1339
Draft
aofei wants to merge 1 commit into
Draft
refactor(web): extract web host runtime and streamline exports#1339aofei wants to merge 1 commit into
aofei wants to merge 1 commit into
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Move the shared web host runtime into `internal/webhost` so the repository keeps a direct ownership boundary around `runner.html`, `game.js`, and related host assets. Assemble web runtime bundles from the engine template, embedded host assets, `ispx.wasm`, and `wasm_exec.js` instead of staging host files through `$GOPATH/bin/ispx`. Rename the reusable runtime export command to `exportwebruntime`, remove the public `exporttemplateweb` concept, and keep the template export step internal to the build scripts. Also remove XBuilder-specific hooks from the shared host runtime so the base web runtime stays product-neutral. Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
aofei
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the shared web host runtime into
internal/webhostso the repository keeps a direct ownership boundary aroundrunner.html,game.js, and related host assets.Assemble web runtime bundles from the engine template, embedded host assets,
ispx.wasm, andwasm_exec.jsinstead of staging host files through$GOPATH/bin/ispx.Rename the reusable runtime export command to
exportwebruntime, remove the publicexporttemplatewebconcept, and keep the template export step internal to the build scripts.Also remove XBuilder-specific hooks from the shared host runtime so the base web runtime stays product-neutral.