fix for recent Unity iOS and google signin libraries#110
Open
umegaya wants to merge 2 commits intogooglesamples:masterfrom
Open
fix for recent Unity iOS and google signin libraries#110umegaya wants to merge 2 commits intogooglesamples:masterfrom
umegaya wants to merge 2 commits intogooglesamples:masterfrom
Conversation
…nd google signin libraries - removes Unity.Tasks.dll because recent Unity has built in support for it - removes missing symbols of GIDSignin (function, error code) - swap preStartUnity instead of application:didFinishLaunchingWithOptions: because recent GIDSignin required to set presentingViewController to work, and correct UIViewController cannot be retrieved application:didFinishLaunchingWithOptions timing. - add general PostProcessor to generated Unity Xcode project can run with OAuth credentials settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
purpose
play-services-resolver-1.2.124.0and found:fixes
Unity.Tasks.dllbecause recent Unity has built in support for itGIDSignin(function, error code)preStartUnityinstead ofapplication:didFinishLaunchingWithOptions:ofUnityAppControllerwithGoogleSignInControllerversion. because recentGIDSigninrequired to setpresentingViewControllerto work, but correctUIViewControllercannot be retrieved onapplication:didFinishLaunchingWithOptionsbeing called.GoogleService-Info.plistand copy it to root of xcode project dirREVERSED_CLIENT_IDas custom URL TypeGoogleSignIn_CanBeSilentto C linkage codesquestion
GIDSignin handleURLis missing. how do I handle these with recent lib?