-
Notifications
You must be signed in to change notification settings - Fork 682
tests: fix Kokoro change detection #8510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
cdce488
ef94b7d
5f44158
1bc836a
091aeee
de467d0
60d420f
88d3362
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -4,8 +4,9 @@ | |||||||||||
| # Auto-injected conditional check | ||||||||||||
| # Check if the package directory has changes. If not, skip tests. | ||||||||||||
| if [[ "${RUNNING_IN_CI:-}" == "true" ]]; then | ||||||||||||
| # The package path is hardcoded during migration | ||||||||||||
| RELATIVE_PKG_PATH="handwritten/firestore" | ||||||||||||
| # We're already in the relevant directory, so we only need to check for | ||||||||||||
| # changes relative to that. | ||||||||||||
| RELATIVE_PKG_PATH="." | ||||||||||||
|
Comment on lines
+7
to
+9
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because of the Setting The original hardcoded path
Suggested change
|
||||||||||||
|
|
||||||||||||
| echo "Checking for changes in ${RELATIVE_PKG_PATH}..." | ||||||||||||
|
|
||||||||||||
|
|
||||||||||||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect these were unintentional(?) but should be harmless to throw in here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe they were added by OwlBot automatically, so not in anything I created...