test(spanner): disable annotation copying on ServerStream mocks causing Java 8 crash#13832
Merged
Merged
Conversation
nnicolee
marked this pull request as ready for review
July 20, 2026 14:35
sakthivelmanii
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In JSpecify 1.0.0, the
@NullMarkedannotation targetsElementType.MODULE. BecauseElementType.MODULEwas introduced in Java 9, reflecting on@NullMarkedclasses under Java 8 (JDK 1.8) throwsEnumConstantNotPresentExceptionProxywrapped in anArrayStoreException.In
PartitionedDmlTransactionTest, two mock declarations forServerStreamwere created using the defaultmock(ServerStream.class)without setting.withoutAnnotations(). Mockito attempts to copy annotations on the mock subclasses, triggering the reflection crash on the JSpecify@NullMarkedannotation during Java 8 CI pipelines.Solution
Replaced
mock(ServerStream.class)withmock(ServerStream.class, withSettings().withoutAnnotations())intestExecuteStreamingPartitionedUpdateRSTstreamandtestExecuteStreamingPartitionedUpdateGenericInternalExceptionto match the other passing tests. This disables annotation copying on the mockedServerStreaminstances and bypasses the Java 8 reflection limitations.