Skip to content

chore: migrate java-shared-config to monorepo#13481

Open
jinseopkim0 wants to merge 810 commits into
mainfrom
migrate-java-shared-config-v2
Open

chore: migrate java-shared-config to monorepo#13481
jinseopkim0 wants to merge 810 commits into
mainfrom
migrate-java-shared-config-v2

Conversation

@jinseopkim0

@jinseopkim0 jinseopkim0 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

b/519273974

renovate-bot and others added 30 commits February 14, 2024 15:00
* deps: update actions/github-script action to v7

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…rtifact (#755)

* chore: merge doclet test with rest of client-library-checks

* add back in separate test

* update script and permissions

* update script

* update permissions

* update permissions

* update permissions

* rename file

* update permissions

* update script

* replace cd with pushd and popd
…rtifact (#759)

* chore: fix storage downstream check to use sdk-platform-java-config artifact
This check is now running in the stage job and is no longer needed in Github.
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* chore: updating contribution guideline

b/323263307

* exclude CONTRIBUTING.md from templates
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
…771)

* fix: update DocFX profile with properties

* test: see if these changes are needed
* deps: update actions/github-script action to v7

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* deps: update actions/setup-java action to v4

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Comment thread .github/workflows/ci.yaml Outdated
Comment thread .github/workflows/java-shared-config-downstream-dependencies.yaml
Comment thread .github/workflows/java-shared-config-downstream-maven-plugins.yaml
Comment thread java-shared-config/.cloudbuild/cloudbuild-test-a.yaml
@jinseopkim0 jinseopkim0 force-pushed the migrate-java-shared-config-v2 branch from 01eac5a to 84bc89c Compare June 16, 2026 17:48
@jinseopkim0 jinseopkim0 force-pushed the migrate-java-shared-config-v2 branch from 17e3f10 to 7501606 Compare June 16, 2026 23:22
@jinseopkim0 jinseopkim0 force-pushed the migrate-java-shared-config-v2 branch 3 times, most recently from 79cfbc0 to 77df590 Compare June 17, 2026 15:27
@jinseopkim0 jinseopkim0 force-pushed the migrate-java-shared-config-v2 branch from ec1b0ad to 236b59e Compare June 17, 2026 16:32
@jinseopkim0 jinseopkim0 requested a review from blakeli0 June 17, 2026 19:57
Comment thread .kokoro/presubmit/logging-logback-graalvm-native-presubmit.cfg
Comment thread .kokoro/presubmit/shared-config-integration.cfg
@blakeli0

Copy link
Copy Markdown
Contributor

Existing places (e.g. sdk-platform-java-config/pom.xml) that point to released version of java-shared-config in this repo need to be updated to use relative path now.

Comment thread java-shared-config/native-image-shared-config/pom.xml Outdated
Comment thread .github/workflows/java-shared-config-downstream-maven-plugins.yaml Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind sharing how the downstream tests work now? I guess we test the downstream libraries in this repo with the changes in this PR?

@jinseopkim0 jinseopkim0 Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the question. Yes, the downstream checks verify that the proposed changes to java-shared-config in the PR do not break dependency convergence or packaging for the main client libraries in the monorepo.

  1. Local Installation: The workflow first compiles and installs the modified local version of google-cloud-shared-config from the PR branch into the runner's local Maven cache (~/.m2/repository) using .kokoro/build.sh.
  2. Mocking Downstream Usage: The .kokoro/client-library-check.sh script is invoked. Since this script was migrated from the standalone repo, it currently:
    • Clones google-cloud-java at the latest stable tagged release.
    • Rewrites the parent pom reference in sdk-platform-java-config in the cloned repo to point to the local google-cloud-shared-config version we just built in Step 1.
  3. Validation: It then runs dependencies.sh (to run the upper-bound dependency convergence check) and the flatten-plugin-check (to verify flattened POM dependency resolution) on the target client libraries (like BigQuery, Spanner, Storage) using the newly modified configuration.

There may be some optimizations possible to improve this test in the future, but for now, most of the existing testing logic has been re-used.

@jinseopkim0 jinseopkim0 force-pushed the migrate-java-shared-config-v2 branch from 1431d4a to 93a9dbf Compare June 18, 2026 00:43
@jinseopkim0 jinseopkim0 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2026
…est discovery, and restore logback Kokoro configs
@jinseopkim0 jinseopkim0 force-pushed the migrate-java-shared-config-v2 branch from ec1d6d1 to d08aed0 Compare June 18, 2026 08:06
@sonarqubecloud

Copy link
Copy Markdown

@sonarqubecloud

Copy link
Copy Markdown

@jinseopkim0 jinseopkim0 requested a review from blakeli0 June 18, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.