impl(v3): Multiplexed sessions always enabled #15941
Conversation
Summary of ChangesHello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the Spanner client library by making multiplexed sessions the default and only session type for v3. This change simplifies the client's architecture by removing the legacy session pool and its associated configuration options, leading to a more consistent and efficient session management experience. The update primarily involves deprecating old options, removing legacy test code, and ensuring that existing codebases can gracefully transition by suppressing deprecation warnings. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request makes multiplexed sessions the default for Spanner v3, which is a significant and welcome simplification. The changes correctly deprecate the old session pool options and remove a substantial amount of related test code, improving maintainability. The necessary adjustments to enable this by default and suppress deprecation warnings in existing code have been applied broadly. My review includes a couple of minor suggestions to remove commented-out code from tests for better code hygiene.
diegomarquezp
left a comment
diegomarquezp
left a comment
There was a problem hiding this comment.
@diegomarquezp reviewed all commit messages.
Reviewable status: 0 of 42 files reviewed, 2 unresolved discussions (waiting on @diegomarquezp and @scotthart).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## prepare-for-v3.0.0 #15941 +/- ##
======================================================
- Coverage 92.79% 92.62% -0.18%
======================================================
Files 2332 2332
Lines 214327 213322 -1005
======================================================
- Hits 198895 197587 -1308
- Misses 15432 15735 +303 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scotthart
merged commit 54b6476
into
googleapis:prepare-for-v3.0.0
2 participants
This PR changes the default Spanner Session type for v3. All sessions are now Multiplexed Sessions and the legacy Session Pool is no longer used. Session Pool specific tests have been removed. The existing Session Pool related Options are now marked deprecated and will be removed in the future. Compiler deprecation warnings have been squelched in spanner files that include the deprecated Options. The remaining inert Session Pool specific code will be removed at a later date.
This change is