Skip to content

fix(core): parse stdout only in ProcessOutput.json() - #1510

Open
AbhiPra24 wants to merge 1 commit into
google:mainfrom
AbhiPra24:fix/process-output-json-stdout-only
Open

fix(core): parse stdout only in ProcessOutput.json()#1510
AbhiPra24 wants to merge 1 commit into
google:mainfrom
AbhiPra24:fix/process-output-json-stdout-only

Conversation

@AbhiPra24

Copy link
Copy Markdown

Fixes #1505

Summary of Changes

  • Updated ProcessOutput.prototype.json() in src/core.ts to parse this.stdout instead of this.stdall (combined stdout + stderr).
  • Added unit test cases in test/core.test.js confirming that commands/ProcessOutput instances with non-JSON logs on stderr parse stdout JSON correctly without throwing parsing errors.

@goransh-walia

Copy link
Copy Markdown

Clean and minimal — appreciate that it stays scoped to the actual fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ProcessOutput.json() parses combined stdout+stderr, breaking on CLIs that log progress to stderr

2 participants