Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ tidy: descriptions
executor/*.cc

lint:
CGO_ENABLED=1 $(HOSTGO) install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.6.2
CGO_ENABLED=1 $(HOSTGO) install github.com/golangci/golangci-lint/v2/cmd/golangci-lint
CGO_ENABLED=1 $(HOSTGO) build -buildmode=plugin -o bin/syz-linter.so ./tools/syz-linter
bin/golangci-lint run ./...

Expand Down
7 changes: 1 addition & 6 deletions dashboard/app/aidb/crud.go
Original file line number Diff line number Diff line change
Expand Up @@ -360,12 +360,7 @@ func dbClient(ctx context.Context) (*spanner.Client, error) {
path := fmt.Sprintf("projects/%v/instances/%v/databases/%v",
appID, Instance, Database)
// We use background context for the client, so that it survives the request.
client, err := spanner.NewClientWithConfig(context.Background(), path, spanner.ClientConfig{
SessionPoolConfig: spanner.SessionPoolConfig{
MinOpened: 1,
MaxOpened: 20,
},
})
client, err := spanner.NewClientWithConfig(context.Background(), path, spanner.ClientConfig{})
if err != nil {
return nil, err
}
Expand Down
2 changes: 1 addition & 1 deletion dashboard/app/app.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Copyright 2017 syzkaller project authors. All rights reserved.
# Use of this source code is governed by Apache 2 LICENSE that can be found in the LICENSE file.

runtime: go124
runtime: go126
app_engine_apis: true

# With the f2 setting, the app episodically crashes with:
Expand Down
2 changes: 1 addition & 1 deletion dashboard/app/email_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -950,7 +950,7 @@ func TestSubjectTitleParser(t *testing.T) {
} else if title != test.outTitle {
t.Fatalf("subj: %q, expected title=%q, got %q", test.inSubject, test.outTitle, title)
} else if seq != test.outSeq {
t.Fatalf("subj: %q, expected seq=%q, got %q", test.inSubject, test.outSeq, seq)
t.Fatalf("subj: %q, expected seq=%v, got %v", test.inSubject, test.outSeq, seq)
}
}
}
Expand Down
271 changes: 136 additions & 135 deletions go.mod

Large diffs are not rendered by default.

1,919 changes: 293 additions & 1,626 deletions go.sum

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions pkg/ast/format.go
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ func fmtExpressionRec(sb *strings.Builder, t *Type, parentPrio int) {
case OperatorOr:
sb.WriteString("||")
default:
panic(fmt.Sprintf("unknown operator %q", be.Operator))
panic(fmt.Sprintf("unknown operator %v", be.Operator))
}
sb.WriteByte(' ')
fmtExpressionRec(sb, be.Right, myPrio)
Expand All @@ -289,7 +289,7 @@ func operatorPrio(op Operator) int {
return info.prio
}
}
panic(fmt.Sprintf("unknown operator %q", op))
panic(fmt.Sprintf("unknown operator %v", op))
}

func comma(i int, or string) string {
Expand Down
2 changes: 1 addition & 1 deletion pkg/ast/scanner.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ func init() {
if tok == tokIllegal {
continue
}
tok2str[tok] = fmt.Sprintf("%q", ch)
tok2str[tok] = fmt.Sprintf("%q", rune(ch))
}
}

Expand Down
4 changes: 2 additions & 2 deletions pkg/compiler/gen.go
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ func (comp *compiler) genSyscall(n *ast.Call, argSizes []uint64) *prog.Syscall {
case flagAttr:
fld.SetBool(val != 0)
default:
panic(fmt.Sprintf("unexpected attrDesc type: %q", desc.Type))
panic(fmt.Sprintf("unexpected attrDesc type: %v", desc.Type))
}
}
for desc, val := range stringAttrs {
Expand All @@ -153,7 +153,7 @@ func (comp *compiler) genSyscall(n *ast.Call, argSizes []uint64) *prog.Syscall {
case stringAttr:
fld.SetString(val)
default:
panic(fmt.Sprintf("unexpected attrDesc type: %q", desc.Type))
panic(fmt.Sprintf("unexpected attrDesc type: %v", desc.Type))
}
}
fields, _ := comp.genFieldArray(n.Args, argSizes)
Expand Down
4 changes: 2 additions & 2 deletions pkg/cover/backend/gvisor.go
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,10 @@ func gvisorSymbolize(bin, srcDir string) ([]*Frame, error) {
func gvisorParseLine(s *bufio.Scanner) (*Frame, error) {
pc, err := strconv.ParseUint(s.Text(), 0, 64)
if err != nil {
return nil, fmt.Errorf("read pc %q, but no line info", pc)
return nil, fmt.Errorf("read pc %x, but no line info", pc)
}
if !s.Scan() {
return nil, fmt.Errorf("read pc %q, but no line info", pc)
return nil, fmt.Errorf("read pc %x, but no line info", pc)
}
match := gvisorLineRe.FindStringSubmatch(s.Text())
if match == nil {
Expand Down
2 changes: 1 addition & 1 deletion pkg/instance/instance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func TestExecprogCmd(t *testing.T) {
t.Errorf("bad sandbox: %q, want: %q", *flagSandbox, "namespace")
}
if *flagSandboxArg != 3 {
t.Errorf("bad sandbox_arg: %q, want: %q", *flagSandboxArg, 3)
t.Errorf("bad sandbox_arg: %v, want: %v", *flagSandboxArg, 3)
}
if *flagSignal {
t.Errorf("bad signal: %v, want: %v", *flagSignal, false)
Expand Down
2 changes: 1 addition & 1 deletion prog/expr.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func (bo BinaryExpression) Evaluate(finder ArgFinder) (uint64, bool) {
}
return 0, true
}
panic(fmt.Sprintf("unknown operator %q", bo.Operator))
panic(fmt.Sprintf("unknown operator %v", bo.Operator))
}

func (v *Value) Evaluate(finder ArgFinder) (uint64, bool) {
Expand Down
110 changes: 0 additions & 110 deletions tools/syz-gemini-seed/gemini-seed.go

This file was deleted.

Loading