Skip to content

tp/ui: Add support for aflags#5210

Open
sashwinbalaji wants to merge 4 commits intodev/sashwinbalaji/aflags_devicefrom
dev/sashwinbalaji/aflags_tp
Open

tp/ui: Add support for aflags#5210
sashwinbalaji wants to merge 4 commits intodev/sashwinbalaji/aflags_devicefrom
dev/sashwinbalaji/aflags_tp

Conversation

@sashwinbalaji
Copy link
Member

Trace Processor:

  • Added android_aflags table in android_tables.py.
  • Implemented parsing for AndroidAflags packets in AndroidProbesParser.
  • Added aflags.sql standard library module with android_aflags view.
  • Added diff tests in tests_aflags.py.

UI:

  • Updated TraceInfoPage Android tab to display aflags data.
  • Added a new 'Android Aflags' section with a detailed grid.

Bug: b/314981157
Test: diff_test_trace_processor.py --name-filter='AndroidAflags'
Test: Manually verified UI with a trace containing aflags

@sashwinbalaji sashwinbalaji requested a review from a team as a code owner March 20, 2026 10:24
Copy link
Member

@stevegolton stevegolton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the UI side

@github-actions
Copy link

github-actions bot commented Mar 20, 2026

@sashwinbalaji sashwinbalaji force-pushed the dev/sashwinbalaji/aflags_tp branch from 07bf2bf to dd3cd31 Compare March 20, 2026 17:52
This data source captures snapshots of Android aconfig flags.
It invokes 'aflags list --format proto' and parses the binary protobuf.

The data source supports one-shot capture at the start of the trace
or periodic polling. It uses an incremental state to only emit flags
that have changed since the last snapshot.

The trace format uses raw strings for flag metadata (package, name, etc.)
to keep the implementation simple and avoid interning complexity,
adding ~120KB per full system snapshot.

Test: perfetto_unittests --gtest_filter='AndroidAflagsDataSourceTest.*'
Test: record_android_trace with android.aflags data source
Change-Id: Icff7ad647df9c332e1e9a1f94b5fc935b19f2a12
Change-Id: I905dbde109dc9d7d983a9b9d0d442dec8037106a
Trace Processor:
- Added android_aflags table in android_tables.py.
- Implemented parsing for AndroidAflags packets in AndroidProbesParser.
- Added aflags.sql standard library module with android_aflags view.
- Added diff tests in tests_aflags.py.

UI:
- Updated TraceInfoPage Android tab to display aflags data.
- Added a new 'Android Aflags' section with a detailed grid.

Test: diff_test_trace_processor.py --name-filter='AndroidAflags'
Test: Manually verified UI with a trace containing aflags
Change-Id: I1314b3017e23f94a66748b4e3e908c70beda715f
Change-Id: Ibb630a3867b2d030baa019d11409d52d6ac8bba5
@sashwinbalaji sashwinbalaji force-pushed the dev/sashwinbalaji/aflags_device branch from 40a0d73 to 87e2efe Compare March 20, 2026 18:48
@sashwinbalaji sashwinbalaji force-pushed the dev/sashwinbalaji/aflags_tp branch from dd3cd31 to a0960ef Compare March 20, 2026 18:48
@sashwinbalaji sashwinbalaji force-pushed the dev/sashwinbalaji/aflags_device branch from 87e2efe to cc4c3d8 Compare March 20, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants