Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
zezeozue
force-pushed
the
dev/zezeozue/dev/zezeozue/ahat-split
branch
5 times, most recently
from
10cfef5 to
e416a81
Compare
stevegolton
left a comment
stevegolton
left a comment
There was a problem hiding this comment.
Haven't finished going through everything yet but I noticed you were duplicating a lot of widgets and styles - please use the builtin ones to avoid bloating the bundle and to offer a consistient look and feel.
python/tools/check_ratchet.py
Outdated
| from dataclasses import dataclass | ||
|
|
||
| EXPECTED_ANY_COUNT = 29 | ||
| EXPECTED_ANY_COUNT = 32 |
There was a problem hiding this comment.
Can we avoid incrementing this number please? Use unknown if you can
ui/src/public/sidebar.ts
Outdated
| title: 'Current Trace', | ||
| summary: 'Actions on the current trace', | ||
| }, | ||
| ahat: { |
There was a problem hiding this comment.
I don't think we want to have a specifc AHAT section in the sidebar, it's a bit too specific.
If you want subpages, add subtabs or a sub menu within the page itself.
|
|
||
| // ─── Theme tokens ──────────────────────────────────────────────────────────── | ||
|
|
||
| :root { |
There was a problem hiding this comment.
Please use the builtin theme colors.
| }); | ||
| } | ||
|
|
||
| constructor(_trace: Trace) {} |
| ? m('div', {class: 'ah-card--compact ah-mb-3'}, [ | ||
| m('span', {class: 'ah-info-grid__label'}, 'Heap: '), | ||
| m( | ||
| 'select', |
There was a problem hiding this comment.
Pleas use the builtin select widget
| {class: 'ah-table-wrap'}, | ||
| m( | ||
| 'table', | ||
| {class: 'ah-table'}, |
zezeozue
force-pushed
the
dev/zezeozue/dev/zezeozue/ahat-split
branch
5 times, most recently
from
866fe3a to
d8209f1
Compare
Add heap_graph_object_data and heap_graph_primitive tables for HPROF heap dumps. Add __intrinsic_heap_graph_get_array() SQL function to retrieve raw primitive array bytes by blob ID. Remove GenerateArrayValueStrings() which created multi-MB interned strings for large arrays. Change-Id: Iba8909797f89aec4cf43c7b0f8c9a68c6efeb615
zezeozue
force-pushed
the
dev/zezeozue/dev/zezeozue/ahat-split
branch
2 times, most recently
from
37bdaba to
578de7a
Compare
Add the com.android.HeapDumpExplorer plugin, inspired by Android's ahat tool, with navigation, shared components, queries, and all heap analysis views: overview dashboard, classes, objects, instances, dominators, bitmap gallery, and strings. Uses DataGrid with SQLDataSource for efficient sorting and filtering of large datasets. Change-Id: I28d4f8ef7b3b949e2e1a5fefe3aeefddab2b3c5f
…orer Co-Authored-By: Claude Opus 4.6 <[email protected]> Change-Id: I6621cbe4aff8f575cf419759b3e972b6d79745aa
zezeozue
force-pushed
the
dev/zezeozue/dev/zezeozue/ahat-split
branch
from
578de7a to
0a2820b
Compare
2 participants
DO NOT SUBMIT