Enable SmolLM 3 template. #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ochafik
suggested changes
Jul 10, 2025
- Add `replace` method for string type and update unit tests. - Support slice expression with omitted start or end index and update unit tests. - Fix the bug that `in` operator does not work for string type. - Update testing script to support fetching `chat-template.jinja` when the template is not in `tokenizer_config.json`. Test passed with SmolLM 3B model: https://huggingface.co/HuggingFaceTB/SmolLM3-3B
ochafik
approved these changes
Jul 11, 2025
ochafik
added a commit
to ochafik/minja
that referenced
this pull request
Nov 2, 2025
* Enable SmolLM 3 template. - Add `replace` method for string type and update unit tests. - Support slice expression with omitted start or end index and update unit tests. - Fix the bug that `in` operator does not work for string type. - Update testing script to support fetching `chat-template.jinja` when the template is not in `tokenizer_config.json`. Test passed with SmolLM 3B model: https://huggingface.co/HuggingFaceTB/SmolLM3-3B * Update test cases of string replace. --------- Co-authored-by: Olivier Chafik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replacemethod for string type and update unit tests.inoperator does not work for string type.chat-template.jinjawhen the template is not intokenizer_config.json.Test passed with SmolLM 3B model:
https://huggingface.co/HuggingFaceTB/SmolLM3-3B