Skip testCreateParentDirectories_noPermission when running as root#8260
Open
mvanhorn wants to merge 1 commit intogoogle:masterfrom
Open
Skip testCreateParentDirectories_noPermission when running as root#8260mvanhorn wants to merge 1 commit intogoogle:masterfrom
mvanhorn wants to merge 1 commit intogoogle:masterfrom
Conversation
When running tests as root, filesystem permission checks are bypassed, so MoreFiles.createParentDirectories succeeds instead of throwing IOException. Skip the test in this case, similar to the existing Windows skip. Fixes google#7328
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7328
MoreFilesTest.testCreateParentDirectories_noPermissionexpectsMoreFiles.createParentDirectoriesto throwIOExceptionwhen the parent directory cannot be created due to permissions. However, when running as root, filesystem permission checks are bypassed, so the operation succeeds and the test fails.This PR adds a root user check that skips the test, matching the existing pattern used for Windows.
This contribution was developed with AI assistance (Claude Code).