Fix composeResources crash on android 7 - #3659
Merged
Merged
Conversation
andreia-ferreira
had a problem deploying
to
e2e-approval
April 7, 2026 12:14 — with
GitHub Actions
Failure
andreia-ferreira
had a problem deploying
to
e2e-approval
April 7, 2026 12:14 — with
GitHub Actions
Failure
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3659 +/- ##
=========================================
Coverage 66.79% 66.79%
Complexity 1607 1607
=========================================
Files 363 363
Lines 8980 8980
Branches 1159 1159
=========================================
Hits 5998 5998
Misses 2333 2333
Partials 649 649 🚀 New features to boost your workflow:
|
andreia-ferreira
temporarily deployed
to
e2e-approval
April 7, 2026 12:28 — with
GitHub Actions
Inactive
andreia-ferreira
temporarily deployed
to
e2e-approval
April 7, 2026 13:07 — with
GitHub Actions
Inactive
andreia-ferreira
temporarily deployed
to
e2e-approval
April 7, 2026 13:41 — with
GitHub Actions
Inactive
andreia-ferreira
temporarily deployed
to
e2e-approval
April 7, 2026 14:33 — with
GitHub Actions
Inactive
andreia-ferreira
temporarily deployed
to
e2e-approval
April 7, 2026 15:34 — with
GitHub Actions
Inactive
andreia-ferreira
temporarily deployed
to
e2e-approval
April 7, 2026 16:11 — with
GitHub Actions
Inactive
andreia-ferreira
temporarily deployed
to
e2e-approval
April 7, 2026 17:31 — with
GitHub Actions
Inactive
andreia-ferreira
temporarily deployed
to
e2e-approval
April 8, 2026 08:09 — with
GitHub Actions
Inactive
andreia-ferreira
temporarily deployed
to
e2e-approval
April 8, 2026 08:42 — with
GitHub Actions
Inactive
andreia-ferreira
temporarily deployed
to
e2e-approval
April 8, 2026 09:57 — with
GitHub Actions
Inactive
andreia-ferreira
marked this pull request as ready for review
April 8, 2026 10:37
andreia-ferreira
requested review from
shobhitagarwal1612
and removed request for
gino-m
April 8, 2026 10:37
andreia-ferreira
had a problem deploying
to
e2e-approval
April 9, 2026 15:24 — with
GitHub Actions
Failure
shobhitagarwal1612
approved these changes
Apr 10, 2026
shobhitagarwal1612
temporarily deployed
to
e2e-approval
April 10, 2026 03:08 — with
GitHub Actions
Inactive
andreia-ferreira
temporarily deployed
to
e2e-approval
April 10, 2026 07:50 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3655
After moving the fonts to the shared
:core:uimodule, a crash would happen on android 7java.lang.RuntimeException - Font asset not found composeResources. This is becauseandroidResources.enable = truewas missing from that module's build gradle.This was apparently not required for newer devices because they are more tolerant of missing or differently packaged Android resources at runtime, but on older android versions resource handling is stricter.
This PR adds that missing build.gradle config and updates the CI to run the instrumented tests in parallel with a android 7 device, alongside the current device. This ensures that all new code is compatible with our min SDK without impacting overall runtime since the tests execute concurrently
@shobhitagarwal1612 PTAL?