Fix missing return in SceneUtils::InstantiateMesh error path - #1217
Draft
rootkiller6788 wants to merge 1 commit into
Draft
Fix missing return in SceneUtils::InstantiateMesh error path#1217rootkiller6788 wants to merge 1 commit into
rootkiller6788 wants to merge 1 commit into
Conversation
The bounds check for the mesh index constructed a Status object but never returned it, so an invalid mesh index fell through to an out-of-bounds access of the scene's mesh vector. Return the error status and add a regression test that instantiates a mesh with an index not present in the scene.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SceneUtils::InstantiateMeshchecks that the scene has a base mesh matching the requestedinstance.mesh_index, but the constructed errorStatuswas never returned:The bounds check was therefore a no-op and execution continued to
scene.GetMesh(instance.mesh_index), which performs an uncheckedmeshes_[index]access and crashes on an out-of-range index.This fix returns the error status as the surrounding code clearly intends, and adds a regression test that instantiates a mesh with an index not present in the scene.
Verification
Built
draco_tests(MinGW,DRACO_TRANSCODER_SUPPORTED=ON):SceneUtilsTest.TestInstantiateMeshWithInvalidMeshIndextest segfaults (exit code 139) due to the out-of-bounds access.InstantiateMeshreturns an error status.The existing
TestInstantiateMeshandTestInstantiateMeshWithIdentityTransformationtests are unaffected.