fix: Move @JsonCreator inside LiveRequest Builder#1281
Open
hemasekhar-p wants to merge 1 commit into
Open
Conversation
8d2ed4c to
5233d54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
LiveRequest.fromJsonStringcannot deserialize any LiveRequest (@JsonCreatordeclared outsideBuilder) #1274Problem:
LiveRequest.fromJsonString()throws a JacksonInvalidDefinitionExceptionfor all valid JSON inputs, completely preventing deserialization. This occurs because the@JsonCreatormethod was declared in the outerLiveRequest.Builderclass. Jackson requires the creator method to be located strictly inside the builder class to properly instantiate the AutoValue builder.Solution:
Moved the @JsonCreator method inside the
LiveRequest.Builderclass to instantiate properly.Testing Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed java test results.
Manual End-to-End (E2E) Tests:
LiveRequest.builder().content(content).close(false).build();toJson().LiveRequest.fromJsonString().Before the fix, this sequence immediately threw
InvalidDefinitionException. After the fix, the object is correctly reconstructed and evaluated perfectly.Checklist