feat(settings): rename negative settings to positive naming (disable* -> enable*)#14142
Conversation
Summary of ChangesHello @afarber, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors several boolean configuration settings to enhance user experience and consistency. By standardizing naming conventions from 'disableX' to 'enableX' and inverting their default values, the system avoids confusing double negatives. Crucially, it includes robust migration logic to ensure that existing user settings are automatically updated without data loss or manual intervention, making the transition transparent for users. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request standardizes boolean toggle settings to use positive "Enable X" naming, which is a great improvement for UX consistency. The changes are extensive, touching documentation, configuration schemas, tests, and UI components. The inclusion of automatic migration logic for existing user configurations is well-implemented. My main feedback is a suggestion to refactor the migration logic for general settings to be more efficient and maintainable by combining multiple file writes into one.
8e12c88 to
82188f5
Compare
0f92014 to
3e10d41
Compare
2ab953c to
8fa176b
Compare
7025f52 to
6ccb3b2
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request is a great step towards standardizing boolean toggle settings to use positive naming, which improves consistency and user experience. The automatic migration for existing user configurations is a thoughtful addition. The changes are comprehensive, covering documentation, configuration, tests, and UI components. I've identified one area for improvement in the migration logic to make it more robust for future changes.
a1fe4e3 to
e9565c7
Compare
devr0306
left a comment
There was a problem hiding this comment.
Great job on this! A few comments but otherwise mostly looks good. A PR recently got merged which enables defaults on settings so some of the ?? could be removed too.
583c289 to
34a7d1d
Compare
34a7d1d to
716b1cc
Compare
ece76b7 to
93a486b
Compare
f8ecbaa to
0c5d5bd
Compare
jacob314
left a comment
There was a problem hiding this comment.
Thanks for adding this! To unblock some work I'll make a couple tweaks on top of this PR so we can land it today.
0c5d5bd to
852b425
Compare
852b425 to
6942caa
Compare
fix: address settings refactoring issues and remove deprecated migration tests - Removed tests for migrateSettingsToV1 and needsMigration which were officially removed. - Fixed missing imports (debugLogger, ExtensionManager, path, etc.) and unused variables in settings files. - Resolved crash in handleAutoUpdate.test.ts by providing missing settings properties. - Updated Config mock in useAtCompletion_agents.test.ts to include missing methods. - Regenerated settings documentation to keep it in sync with schema changes. More fixes
6942caa to
8e4ce83
Compare
… -> enable*) (#14142) Co-authored-by: jacob314 <[email protected]>
|
Subject: Confirmation of Merge for Pull Request #14142
Dear Jacob,
Thank you for the update. I would like to confirm that the merge of pull
request #14142 has been completed successfully.
Should there be any further actions required or if you need additional
information, please feel free to reach out.
Best regards,
[Your Name]
[Your Position]
[Your Contact Information]
Vào Thứ 7, 17 thg 1, 2026 vào lúc 05:43 Jacob Richman <
***@***.***> đã viết:
… Merged #14142 <#14142>
into main.
—
Reply to this email directly, view it on GitHub
<#14142 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BTW7LWWXXEKPXPWBTG3Q4734HFSRZAVCNFSM6AAAAACNREAJYWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRSGEYDMOBZGMYTSMA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***
com>
|
…ositive naming (disable* -> enable*) (google-gemini#14142)

Summary
Standardize boolean toggle settings to use positive "Enable X" naming instead of "Disable X" to avoid double negatives and improve UX consistency. Adds automatic migration for existing user configurations.
Details
Migration logic in
migrateDeprecatedSettings()automatically converts old settings with inverted values. Old configs likedisableAutoUpdate: truebecomeenableAutoUpdate: false.Also renamed internal parameter
isAutoUpdateDisabledtoisAutoUpdateEnabledin installationInfo.ts for consistent positive boolean logic throughout the codebase.Note:
security.disableYoloModeintentionally kept as-is since "disable" framing is appropriate for a dangerous mode.Related Issues
Fixes #14035, #15013, #13380, and partially #15237
How to Validate
- "Enable Auto Update" as OFF
- "Enable Update Prompts" as OFF
- "Enable Loading Phrases" as OFF
- "Enable Fuzzy Search" as OFF
- "Disable YOLO Mode" as ON (unchanged, kept as-is)
Pre-Merge Checklist