Open
Conversation
Paul-Lez
reviewed
Mar 22, 2026
Collaborator
Paul-Lez
left a comment
Paul-Lez
left a comment
There was a problem hiding this comment.
Hi, thanks for the contribution! Note that your PR doesn't conform to the repo style guidelines - could you take a look at conventions outlined in the README.md and AGENTS.md?
Author
|
Thank you for your response! Sure, I will look into it and make necessary changes. |
Paul-Lez
reviewed
Mar 23, 2026
Paul-Lez
reviewed
Mar 23, 2026
Collaborator
Paul-Lez
left a comment
Paul-Lez
left a comment
There was a problem hiding this comment.
It seems that there are a few related results mentioned on the wiki page. What do you think of adding them (e.g. the fact that it has been verified up to large n, but that there is a conjecture on the density of the set of counterexamples, and that there's also some modified version of the conjecture that has been stated)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the formal statement for Agrawal's Conjecture (Issue #3606) in the
NumberTheorydirectory.The formalization uses:
Polynomial (ZMod n)for the base ring.Ideal.Quotientto represent the congruence moduloI have verified that the file builds successfully with
lake build. Kindly let me know if any changes to the quotient ring representation or naming conventions are needed.Thanks!