Typescript, CI, start/stop methods, dev script, and new options#18
Open
Nathan-Schwartz wants to merge 1 commit intogoldfire:masterfrom
Open
Typescript, CI, start/stop methods, dev script, and new options#18Nathan-Schwartz wants to merge 1 commit intogoldfire:masterfrom
Nathan-Schwartz wants to merge 1 commit intogoldfire:masterfrom
Conversation
4f56cfc to
1a3e5b8
Compare
Author
|
Hey @goldfire, I'm sure you're busy but I'd love to get some feedback on this when you get time 🙂 |
Author
|
@goldfire do you have an idea of when you'll get a chance to review this? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
User facing:
autoStartoptionenableStrictWeightModeoption to be more aggressive about making the highest-weighted node the leader (may help with Cluster leader election multiple issues mKeRix/room-assistant#860)Dev facing: