Add local property to elements#52
Merged
goetas merged 1 commit intogoetas-webservices:masterfrom Aug 22, 2020
Merged
Conversation
This was referenced Feb 12, 2020
Member
|
Could you please simplify a bit this XMLs used for tests, reducing them to the minimum needed? I think that all those props are not needed. It will make those tests more readable and maintainable in the future. |
Toilal
force-pushed
the
element-local-property
branch
2 times, most recently
from
a9ea3c2 to
59efafc
Compare
Toilal
force-pushed
the
element-local-property
branch
from
59efafc to
47ceba4
Compare
Contributor
Author
|
@goetas I have reduce the tests to the minimum. I hope you will be able to merge soon now 👍 |
Member
|
Thanks for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to goetas-webservices/soap-client#46