element: ak-checkbox #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* element/ak-icon: Prettier has opinions. Added some docs. Prettier has opinions. Prettier's opinions sometimes suck. Prettier still has opinions. Added types to make Teffen happy. rem, not em, for the pseudo-patternfly icon sizes derivef from fontawesome. Otherwise, the multiplicative effect is... dramatic. Icons as big as your monitor. Removing unneeded references. Added FontAwesome icon sizes to repetoire. Also: Prettier has opinions. # ak-icon Icon maybe final Initial check-in for icons. Still needs testing. .
* element/ak-icon: Updating with linty fixes.
… updated the stories.
* element/ak-icon: Fat-fingered and deleted a crucial expression in icon tests. Fixed!
* main: (37 commits) Forgot to run , and now that I have a hook to do it for me, this is making it whiny. Fixed typo in css. Added comments to the wcc file. This commit revises the WCCSS transpiler, using the regular expression and merge algorithms recommended by the Patternfly 5 React team. Added wccss pass to package.json. Type inference FTW. Needed to put tools build in-line This commit ports the Elements' build tools to Typescript Cleanup. New css build completing. Crawling back to the original starting point, but this time with better tooling. Save point. This commit introduces a dark-mode controller and code. A working dark mode, although with some dubious decisions Build system revised into a more unixy pattern: each script does one thing well. Bump validator from 13.15.15 to 13.15.20 (#10) Bump vite (#9) First stab at the dark-mode controller; it takes orders from the central context, if there is one, but if not, it tries to determine the mode itself by looking at the user's preferences. Revised brand to meet a... more modern standard. npm trusted publisher ...
…as pretty messed up. Switch is now completely and externally themable.
* element/ak-switch: (40 commits) Fixed a lot of bugs-- there was some transitional code in here that was pretty messed up. Switch is now completely and externally themable. Including package-lock, which was lost in the merge. Forgot to run , and now that I have a hook to do it for me, this is making it whiny. Fixed typo in css. Added comments to the wcc file. This commit revises the WCCSS transpiler, using the regular expression and merge algorithms recommended by the Patternfly 5 React team. Added wccss pass to package.json. Type inference FTW. Needed to put tools build in-line This commit ports the Elements' build tools to Typescript Cleanup. New css build completing. Crawling back to the original starting point, but this time with better tooling. Save point. This commit introduces a dark-mode controller and code. A working dark mode, although with some dubious decisions Build system revised into a more unixy pattern: each script does one thing well. Bump validator from 13.15.15 to 13.15.20 (#10) Bump vite (#9) First stab at the dark-mode controller; it takes orders from the central context, if there is one, but if not, it tries to determine the mode itself by looking at the user's preferences. ...
…ode required to swap control & label. Excellent.
* element/ak-switch: Turns out, I didn't need that extra. The grid handled it for me; no code required to swap control & label. Excellent.
…ocumentation has been fixed and updated to reflect this.
* main: (64 commits) Accepted suggestion from @GirlBossRush Update vitest.config.js Update src/ak-button/ak-button.component.ts Update src/ak-button/ak-button.template.ts Typos is dumb, part 2. Typos is dumb. Added comment explaining why href is _removed_ from an anchor when the anchor is disabled. Moving source-maps into devDependencies. I hate wresting with type uncertainty. We now provide the types correctly. NPM between the versions is a massive source of headache. Merge weirdness. Rounding out icon tests. Bump vite (#44) Bump storybook from 9.1.8 to 9.1.17 (#47) bump version Fixing the optimization set in vitest, as recommended on Github. Attempting to fix browser version. Another attempt at getting playwright to play nice. Adjusting test parameters. ...
* main: (64 commits) Accepted suggestion from @GirlBossRush Update vitest.config.js Update src/ak-button/ak-button.component.ts Update src/ak-button/ak-button.template.ts Typos is dumb, part 2. Typos is dumb. Added comment explaining why href is _removed_ from an anchor when the anchor is disabled. Moving source-maps into devDependencies. I hate wresting with type uncertainty. We now provide the types correctly. NPM between the versions is a massive source of headache. Merge weirdness. Rounding out icon tests. Bump vite (#44) Bump storybook from 9.1.8 to 9.1.17 (#47) bump version Fixing the optimization set in vitest, as recommended on Github. Attempting to fix browser version. Another attempt at getting playwright to play nice. Adjusting test parameters. ...
…tion from component.
* element/ak-switch: Fixed dark mode for switch. Updated builder with spread pattern; deleted unused interface declaration from component. Brings switch into the vitest world.
* main: (51 commits) Not sure why tests are failing. Trying test fix. element/ak-timestamp: consistency pass and final check element/ak-divider: consistency check and test update element/ak-empty-state: consistency check Last-minute changes lead to last-minute bugs. elements: structural issues Documentation update elements: fix inconsistent API, UI, and DX issues Consistency pass: fixed some poor name choices and removed the useless interfaces. Applies the new vitest suite to ak-timestamp. OptimizeDeps is hard to get right, apparently. Added lit/localize to the optimizeDeps collection. Playwright-ifying the tests. Not sure how this got lost. element: ak-timeout And divider is now themable and dark-mode capable. Just maintainging a 'prettier' codebase. Updating for release. Empty state now has root CSS definition, making it available for customer customization. ...
* element/ak-switch: (53 commits) Fixed logic for rendering icon and labels. It's confusing, but not as bad as before. Some fixes found with a deeper code analysis pass. Not sure why tests are failing. Trying test fix. element/ak-timestamp: consistency pass and final check element/ak-divider: consistency check and test update element/ak-empty-state: consistency check Last-minute changes lead to last-minute bugs. elements: structural issues Documentation update elements: fix inconsistent API, UI, and DX issues Consistency pass: fixed some poor name choices and removed the useless interfaces. Applies the new vitest suite to ak-timestamp. OptimizeDeps is hard to get right, apparently. Added lit/localize to the optimizeDeps collection. Playwright-ifying the tests. Not sure how this got lost. element: ak-timeout And divider is now themable and dark-mode capable. Just maintainging a 'prettier' codebase. ...
* element/ak-switch: Removed silence flag that was blocking error reporting.
❌ Deploy Preview for authentik-elements-storybook failed. Why did it fail? →
|
kensternberg-authentik
changed the base branch from
main
to
element/ak-switch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Patternfly 5 checkbox component to the element zoo.