Conversation
|
Unless this design is only going to be used for KB, IMO it should be made its own component and not put in the KB styles/code. |
AdrienClairembault
left a comment
There was a problem hiding this comment.
I think the upload to tmp part should start immediately when the file is added, that's how it works on gmail for example.
Also, if I upload a file that is not allowed (a .json for example), I don't have any error and my file is just silently ignored.
51782e3 to
aa0a441
Compare
|
Removed dead code for file verification. Add immediate uploads. |
AdrienClairembault
left a comment
There was a problem hiding this comment.
Looks good functionally but I'd like to wait for @cedric-anne opinion on the technical side as this changes a lot compared to our traditional "legacy" jquery file uploader system.
If we validate it, it should indeed be move into a re-usable module so it can be used for others features as a replacement of the old jquery file uploader.
The current uploader component we use is not maintained anymore, and this is why we had to embed its sources in our repository. Therefore, I think it is a good idea to build our own component, and plan to use it in the whole GLPI code base in a future version. |
aa0a441 to
a542fb5
Compare
|
Extracted the file uploader dropzone markup from article.html.twig into a standalone partial. The JS (FileUploader.js) and SCSS (_file-uploader.scss) were already generic ; this completes the extraction by making the Twig layer reusable too. Tested reusability by replacing Full integration would require an adapter controller. To try the partial anywhere in GLPI : |
8ba250f to
b4c102c
Compare
Description
Add an uploader to documents modal for new KB/
Screenshots (if appropriate):