rule collection generic controller#18999
Draft
SebSept wants to merge 20 commits intoglpi-project:mainfrom
Draft
Conversation
…r' into rule-collection-generic-controller # Conflicts: # src/Glpi/Controller/Rule/RuleListController.php
…page) remove legacy controller replaced by RuleListController wip - / a squash - Généralisation à tous les types de ruleCollection
SebSept
force-pushed
the
rule-collection-generic-controller
branch
from
5fdc7dc to
6c2adeb
Compare
cedric-anne
reviewed
Feb 17, 2025
…e.common.form.php'
Co-authored-by: Cédric Anne <[email protected]>
…page) remove legacy controller replaced by RuleListController wip - / a squash - Généralisation à tous les types de ruleCollection
Co-authored-by: Cédric Anne <[email protected]>
…r' into rule-collection-generic-controller # Conflicts: # front/rule.common.php
cedric-anne
reviewed
Feb 20, 2025
cedric-anne
reviewed
Feb 20, 2025
Comment on lines
36
to
40
| /** | ||
| * Following variables have to be defined before inclusion of this file: | ||
| * @var RuleCollection $rulecollection | ||
| * @var LegacyFileLoadController $this | ||
| */ |
Member
There was a problem hiding this comment.
You should remove this. It will prevent PHPStan to rely on the declared types and will fixes the errors that were added to the baseline.
Suggested change
| /** | |
| * Following variables have to be defined before inclusion of this file: | |
| * @var RuleCollection $rulecollection | |
| * @var LegacyFileLoadController $this | |
| */ |
Contributor
Author
There was a problem hiding this comment.
I did it to be consistent with front/dropdown.common.form.php which also has it's error in the baseline.
It's a useful documentation imo,
- gives autocompletion
- there is new errors that needs to be ignored if we remove this annotations .
------ ----------------------------------------------------------------------
Line rule.common.form.php
------ ----------------------------------------------------------------------
40 Variable $rulecollection might not be defined.
🪪 variable.undefined
40 Variable $this might not be defined.
🪪 variable.undefined
------ ----------------------------------------------------------------------
cedric-anne
reviewed
Feb 20, 2025
Co-authored-by: Cédric Anne <[email protected]>
Co-authored-by: Cédric Anne <[email protected]>
Co-authored-by: Cédric Anne <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.