Fix dropdown fields label when name contains [] chars

[cedric-anne]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	-

Found while testing #17462.

The for attribute of the label was incorrect (e.g. dropdown_myprop[]1246579875) and different from the <select> id (e.g. dropdown_myprop__1246579875) that is generated by:

glpi/src/Dropdown.php

Line 227 in 6edfb3d

$field_id = Html::cleanId("dropdown_" . $params['name'] . $params['rand']);

[AdrienClairembault]

I've let a TODO for this in the dropdownArrayField macro:

Can you delete it ?

Also maybe we need a proper filter/function/macro to avoid repeating this logic in multiple places.

[cedric-anne]

I've let a TODO for this in the dropdownArrayField macro:

Can you delete it ?

Also maybe we need a proper filter/function/macro to avoid repeating this logic in multiple places.

The main problem is that we cannot force the id in the Dropdown::show*() methods, but I do not have time to do better for now.

[cconard96]

How compatible is this change with the one I made in #17323 for "Automatically generated IDs from names may break labels because the name wasn't slugified"?

https://github.com/glpi-project/glpi/pull/17323/files#diff-12e218694082593986b5e9b3dc90adf6ae346b28027f7944ec6c8ca99354fbe5R747

[cedric-anne]

How compatible is this change with the one I made in #17323 for "Automatically generated IDs from names may break labels because the name wasn't slugified"?

https://github.com/glpi-project/glpi/pull/17323/files#diff-12e218694082593986b5e9b3dc90adf6ae346b28027f7944ec6c8ca99354fbe5R747

I think there should not be compatibility issues with this change.