Sub-second accuracy in syslog adapter#382
Sub-second accuracy in syslog adapter#382romanlevin wants to merge 4 commits intogliderlabs:masterfrom
Conversation
josegonzalez
left a comment
There was a problem hiding this comment.
Seems fine, do we need to have tests for this? Would it be better to somehow make this configurable?
@josegonzalez I'm new to contributing to logspout – are you asking me? I'm not super fluent in Go and the tests around the syslog adapter are a bit of the mystery to me at the moment. Making this opt-in with an environment variable should be super simple even for me, but I'm not sure if that's what you meant by "configurable". |
|
Could this be merged and release, please? |
|
Could this be merged and release, please? |
|
Btw this LGTM ... let me know if repo needs to announce call for co-maintainers. |
|
Yeah we should probably do that - I don't maintain the repo but Im sure there are folks that would want to. |
Other than unnecessarily losing timestamp accuracy, this breaks for syslog daemons that expect sub-second accuracy (like
fluentd).