Conversation
| } | ||
|
|
||
| version = '2.1.0' | ||
| version = '2.1.1' |
There was a problem hiding this comment.
Is there some reference discussion that explains why SNAPSHOT builds are not an option for this project? And outside the scope of this PR, is that something that could be relaxed in the future and would you have an idea of the workload?
There was a problem hiding this comment.
I'm not sure if snapshots are actually a problem, I think we just haven't tried them. I would have anticipated that it might cause problems with the update checker, but from a quick review it looks like snapshot tags are already handled. We could have a go with 2.1.1-SNAPSHOT?
There was a problem hiding this comment.
Understood. Maybe only the signing workflow works with release candidate. If using SNAPSHOT is possible, that would be my preference as it's consistent with the other Java projects
There was a problem hiding this comment.
From a quick test it looks like when using a snapshot version the initial build works fine but jpackage then struggles to bundle it. Probably needs investigating as it's own issue.
There was a problem hiding this comment.
The error is something like:
> Task :jpackageImage FAILED
java.lang.IllegalArgumentException: "Version [2.1.0-SNAPSHOT] contains invalid component [0-SNAPSHOT]"
Looking at how QuPath handles this problem:
That looks like replacing the -SNAPSHOT just when running jpackage is a way forward.
3 participants
Per internal discussion, bumps the build version ready for future releases and replaces the old changelog with a link to the releases log in the main readme.