Filtering and sorting#684
Merged
Merged
Conversation
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 from #660
This pull request introduces several improvements and refactors to the GridLanes component, focusing on enhancing native view transition support, improving initialization and cleanup, and adding comprehensive tests. The most important changes are summarized below.
GridLanes View Transition & State Management Enhancements:
GridLanesclass to use native View Transitions API for smooth DOM updates, including methods for tracking active transitions, flushing pending removals, and finalizing movement state. Added granular state management for initialization, sorting, filtering, and transition lifecycle. (packages/shuffle/src/grid-lanes.ts, [1] [2] [3]--shuffle-speed,--shuffle-easing) and ensured they're properly set and removed during initialization and destruction. (packages/shuffle/src/grid-lanes.ts, [1] [2]GridLanesItem Improvements:
isHiddengetter and adispose()method toGridLanesItemfor improved visibility tracking and cleanup of DOM state and styles when items are destroyed. (packages/shuffle/src/grid-lanes-item.ts, [1] [2]view-transition-nameis set to a unique ID when showing items and reset to'none'when hiding, supporting correct view transitions. (packages/shuffle/src/grid-lanes-item.ts, packages/shuffle/src/grid-lanes-item.tsR31-R46)Test Coverage:
data-groups, filter modes, and correct use of view transitions. (packages/shuffle/src/test/grid-lanes.core.test.ts, packages/shuffle/src/test/grid-lanes.core.test.tsR1-R218)Lint & Tooling Updates:
.oxlintrc.jsonto allowno-voidas a statement and disabled a false-positive unicorn rule for NodeList. (.oxlintrc.json, [1] [2]npx tscin the terminal. (.vscode/settings.json, .vscode/settings.jsonR1-R5)These changes collectively modernize the GridLanes component, improve its reliability and developer experience, and ensure robust test coverage for new and existing features.