Skip to content

Add go firewall allowed set to shared/go-make.md#21014

Merged
pelikhan merged 2 commits intomainfrom
copilot/add-go-firewall-allowed-set
Mar 15, 2026
Merged

Add go firewall allowed set to shared/go-make.md#21014
pelikhan merged 2 commits intomainfrom
copilot/add-go-firewall-allowed-set

Conversation

Copy link
Contributor

Copilot AI commented Mar 15, 2026

Workflows importing shared/go-make.md lacked access to Go ecosystem domains (e.g. proxy.golang.org, sum.golang.org, pkg.go.dev), which is needed since the shared file provides mcpscripts-go and mcpscripts-make tools that invoke go commands requiring network access.

Changes

  • shared/go-make.md: Added network.allowed: [go] to frontmatter — expands to go.dev, golang.org, proxy.golang.org, sum.golang.org, pkg.go.dev, goproxy.io, storage.googleapis.com
  • Lock files: Recompiled all 173 workflows; importing workflows (smoke-claude, go-logger, daily-cli-performance) now include Go domains in their --allow-domains list via the existing import union merge in MergeNetworkPermissions
# shared/go-make.md
network:
  allowed:
    - go
mcp-scripts:
  go: ...
  make: ...

Copilot AI and others added 2 commits March 15, 2026 01:44
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan pelikhan marked this pull request as ready for review March 15, 2026 01:56
Copilot AI review requested due to automatic review settings March 15, 2026 01:56
@pelikhan pelikhan merged commit 1a426d0 into main Mar 15, 2026
66 checks passed
@pelikhan pelikhan deleted the copilot/add-go-firewall-allowed-set branch March 15, 2026 01:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Expands workflow firewall permissions for any workflow importing shared/go-make.md so go commands can reach required Go ecosystem domains.

Changes:

  • Added network.allowed: [go] to the shared/go-make.md frontmatter.
  • Updated generated workflow lockfiles to include the go ecosystem in GH_AW_INFO_ALLOWED_DOMAINS and expand the --allow-domains list accordingly.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
.github/workflows/shared/go-make.md Adds network.allowed: [go] so imported workflows automatically permit Go ecosystem network access.
.github/workflows/smoke-claude.lock.yml Regenerated lock metadata and allowed-domain sets to include go.
.github/workflows/go-logger.lock.yml Regenerated lock metadata and expanded --allow-domains to include Go ecosystem domains.
.github/workflows/daily-cli-performance.lock.yml Regenerated lock metadata and expanded --allow-domains to include Go ecosystem domains.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copilot stopped work on behalf of pelikhan due to an error March 15, 2026 02:01
Copilot stopped work on behalf of pelikhan due to an error March 15, 2026 02:01
Copilot stopped work on behalf of pelikhan due to an error March 15, 2026 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants