Conversation
Co-authored-by: pelikhan <[email protected]>
Co-authored-by: pelikhan <[email protected]>
|
❌ Smoke Copilot SDK failed. Please review the logs for details. |
|
🧪 Smoke Project is now testing project operations... |
|
❌ Changeset Generator failed. Please review the logs for details. |
|
🧪 Smoke Temporary ID is now testing temporary ID functionality... |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation... |
|
✅ Smoke Temporary ID completed successfully. Temporary ID validation passed. |
Agent Container Tool Check
Result: 12/12 tools available ✅ All required development tools are present and accessible in the agent container environment.
|
|
@copilot recompile |
|
✅ Smoke Project completed successfully. All project operations validated. |
|
🎯 Smoke Test Results: PARTIAL PRs Reviewed (GitHub MCP):
PRs Queried (safeinputs-gh):
Test Results:
Overall Status: PARTIAL (8/8 core tests passed, 2 MCP tests skipped due to unavailable tools) cc @pelikhan
|
There was a problem hiding this comment.
Smoke test review complete. Changes correctly disable LLM gateway for Codex engine by returning -1 from SupportsLLMGateway(). All related tests properly updated.
📰 BREAKING: Report filed by Smoke Copilot for issue #15748
Co-authored-by: pelikhan <[email protected]>
Workflows recompiled. Updated 10 Codex workflow lock files that now:
Commit: c7466cc Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
🧪 Smoke Temporary ID is now testing temporary ID functionality... |
|
❌ Smoke Copilot SDK failed. Please review the logs for details. |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
✅ Changeset Generator completed successfully! |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
🧪 Smoke Project is now testing project operations... |
|
✅ Smoke Temporary ID completed successfully. Temporary ID validation passed. |
Agent Container Tool Check ✅All required development tools are available in the agent container environment.
Result: 12/12 tools available ✅ PASS Smoke test completed successfully - all development tools are accessible.
|
|
✅ Smoke Project completed successfully. All project operations validated. |
|
|
|
Smoke test (Codex) summary:
|
There was a problem hiding this comment.
💥 Automated smoke test review - all systems nominal!
💥 [THE END] — Illustrated by Smoke Claude for issue #15748
There was a problem hiding this comment.
Pull request overview
This PR disables LLM gateway support for the Codex engine, simplifying its architecture by removing the API proxy layer. The change aligns Codex with other engines that don't require LLM gateway proxying (like Copilot and Custom engines).
Changes:
- Modified Codex engine's
SupportsLLMGateway()to return -1 instead of port 10001 - Updated 4 test files to verify Codex no longer uses api-proxy images or --enable-api-proxy flags
- Recompiled 10 Codex workflow lock files to remove api-proxy Docker images and --enable-api-proxy flags from AWF commands
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/codex_engine.go | Changed SupportsLLMGateway() to return -1, indicating no gateway support |
| pkg/workflow/strict_mode_llm_gateway_test.go | Updated test names and assertions to reflect Codex lacking LLM gateway support |
| pkg/workflow/enable_api_proxy_test.go | Updated test to verify Codex AWF commands exclude --enable-api-proxy flag |
| pkg/workflow/docker_api_proxy_test.go | Updated test to verify Codex workflows exclude api-proxy Docker image |
| .github/workflows/smoke-codex.lock.yml | Removed api-proxy image and --enable-api-proxy flag from compiled workflow |
| .github/workflows/issue-arborist.lock.yml | Removed api-proxy image and --enable-api-proxy flag from compiled workflow |
| .github/workflows/duplicate-code-detector.lock.yml | Removed api-proxy image and --enable-api-proxy flag from compiled workflow |
| .github/workflows/deep-report.lock.yml | Removed api-proxy image and --enable-api-proxy flag from compiled workflow |
| .github/workflows/daily-performance-summary.lock.yml | Removed api-proxy image and --enable-api-proxy flag from compiled workflow |
| .github/workflows/daily-observability-report.lock.yml | Removed api-proxy image and --enable-api-proxy flag from compiled workflow |
| .github/workflows/daily-issues-report.lock.yml | Removed api-proxy image and --enable-api-proxy flag from compiled workflow |
| .github/workflows/daily-fact.lock.yml | Removed api-proxy image and --enable-api-proxy flag from compiled workflow |
| .github/workflows/codex-github-remote-mcp-test.lock.yml | Removed api-proxy image and --enable-api-proxy flag from compiled workflow |
| .github/workflows/changeset.lock.yml | Removed api-proxy image and --enable-api-proxy flag from compiled workflow |
| .changeset/patch-disable-codex-llm-gateway.md | Added changeset documenting the patch-level change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The Codex engine no longer requires LLM gateway proxying for API requests. Updated
SupportsLLMGateway()to return -1, signaling no gateway support.Changes
pkg/workflow/codex_engine.go: ChangedSupportsLLMGateway()return value fromconstants.CodexLLMGatewayPort(10001) to -1--enable-api-proxyflag to AWF commandsapi-proxyDocker image from download steps--enable-api-proxyflag from AWF commandsExample
The convention is: positive port numbers indicate LLM gateway support, -1 indicates no support. This change aligns Codex with Copilot and Custom engines, which also return -1.
Affected Workflows
The following Codex workflows were recompiled with the updated engine behavior:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Changeset