Fix ST1005 linting errors in docker validation error messages by Copilot · Pull Request #15710 · github/gh-aw

Copilot · 2026-02-14T16:30:26Z

Go staticcheck rule ST1005 requires error strings to not be capitalized unless starting with proper nouns, acronyms, or exported identifiers.

Changes

Lowercased error message prefixes in pkg/workflow/docker_validation.go:

// Before
return fmt.Errorf("Docker not installed - could not validate container image '%s'...", image)
return fmt.Errorf("Docker daemon not running - could not validate container image '%s'...", image)

// After  
return fmt.Errorf("docker not installed - could not validate container image '%s'...", image)
return fmt.Errorf("docker daemon not running - could not validate container image '%s'...", image)

This resolves the two ST1005 violations that were blocking CI.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://api.github.com/graphql
- Triggering command: /usr/bin/gh gh repo view --json owner,name --jq .owner.login + "/" + .name 64/pkg/tool/linux_amd64/cgo GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/cgo env -json GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linuTest User (http block)
- Triggering command: /usr/bin/gh gh repo view --json owner,name --jq .owner.login + "/" + .name 64/pkg/tool/linux_amd64/link GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/link env eutil.test GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet (http block)
- Triggering command: /usr/bin/gh gh repo view --json owner,name --jq .owner.login + "/" + .name 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env JqVTrdSpb .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet (http block)
https://api.github.com/repos/actions/ai-inference/git/ref/tags/v1
- Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq .object.sha ry=1 l ache/node/24.13.0/x64/bin/node -errorsas -ifaceassert -nilfunc /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linu--json t-31�� sistency_GoAndJavaScript3399131116/001/test-empty-frontmatter.md -buildtags /usr/bin/gh -errorsas -ifaceassert -nilfunc gh (http block)
https://api.github.com/repos/actions/checkout/git/ref/tags/v3
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq .object.sha se 0733521/b044/vet.cfg .cfg GOINSECURE GOMOD GOMODCACHE ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet (http block)
https://api.github.com/repos/actions/checkout/git/ref/tags/v4
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v4 --jq .object.sha 0733521/b386/_pkg_.a /tmp/go-build4240733521/b016/vet.cfg x_amd64/compile prettier --write 64/bin/go x_amd64/compile -uns�� y8K0/U8Icm1mEpbX-P-mMy8K0 (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v4 --jq .object.sha vaScript3399131116/001/test-frontmatter-with-arrays.md /tmp/go-build4240733521/b026/vet.cfg 0733521/b286/vet.cfg "prettier" --wrigit ache/go/1.25.0/xrev-parse CgoFiles,CXXFile--show-toplevel /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet -uns�� -unreachable=false /tmp/go-build4240733521/b155/vet.cfg /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linux_amd64/vet "prettier" --wrigit go 64/bin/go /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linu12345 (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v4 --jq .object.sha test.txt go /usr/bin/git -json GO111MODULE x_amd64/vet git conf�� runs/20260214-163606-36523/test-3926355996 [email protected] /usr/bin/git l GO111MODULE x_amd64/vet git (http block)
https://api.github.com/repos/actions/checkout/git/ref/tags/v5
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha heck '**/*.cjs' '**/*.ts' '**/*.json' --ignore-path ../../../.pr**/*.json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile m/_n�� -json GO111MODULE .cfg GOINSECURE GOMOD GOMODCACHE ache/go/1.25.0/x64/pkg/tool/linux_amd64/vet (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha /tmp/go-build4240733521/b373/_pkg_.a l /usr/bin/git -p github.com/githurev-parse -lang=go1.25 git rev-�� --show-toplevel -goversion /usr/bin/git -c=4 -nolocalimports -importcfg git (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha --git-dir x_amd64/compile /usr/bin/git -json GO111MODULE x_amd64/vet git rev-�� --show-toplevel _ohjoHz/H0GNPt5I^remote\..*\.gh-resolved$ /usr/bin/git b/workflows GO111MODULE x_amd64/vet git (http block)
https://api.github.com/repos/actions/github-script/git/ref/tags/v8
- Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha -c=4 -nolocalimports -importcfg /tmp/go-build4240733521/b385/importcfg -pack /home/REDACTED/work/gh-aw/gh-aw/pkg/fileutil/fileutil.go /home/REDACTED/work/gh-aw/gh-aw/pkg/fileutil/fileutil_test.go env json' --ignore-p-errorsas GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha go1.25.0 -c=4 -nolocalimports -importcfg /tmp/go-build4240733521/b389/importcfg -pack /tmp/go-build4240733521/b389/_testmain.go env json' --ignore-path ../../../.prettierignore GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
https://api.github.com/repos/actions/setup-go/git/ref/tags/v4
- Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq .object.sha 0733521/b386/fileutil.test /tmp/go-build4240733521/b020/vet.cfg 0733521/b386/importcfg.link "prettier" --wrigit ache/go/1.25.0/xrev-parse 64/bin/go vHaHtRvkD5Mds/U8Icm1mEpbX-P-mMy8K0/Z2-ZXw9FhOpoporigin estl�� ry=1 /tmp/go-build4240733521/b151/vet.cfg 0733521/b386/_pkg_.a "prettier" --wrigit go 64/bin/go /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linu--json (http block)
https://api.github.com/repos/actions/setup-node/git/ref/tags/v4
- Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq .object.sha -unreachable=false /tmp/go-build4240733521/b018/vet.cfg x_amd64/link "prettier" --wrigit ache/go/1.25.0/xrev-parse 64/bin/go x_amd64/link -ato�� -bool -buildtags 0733521/b382/vet.cfg -errorsas -ifaceassert -nilfunc xN/VlHreHFtS4HERHqN_Jw-/Y2nWGztCZ1zEW7qFL-E7 (http block)
https://api.github.com/repos/github/gh-aw/actions/runs/1/artifacts
- Triggering command: /usr/bin/gh gh run download 1 --dir test-logs/run-1 GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env -json .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet (http block)
https://api.github.com/repos/github/gh-aw/actions/runs/12345/artifacts
- Triggering command: /usr/bin/gh gh run download 12345 --dir test-logs/run-12345 GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linuTest User env -json .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet (http block)
https://api.github.com/repos/github/gh-aw/actions/runs/12346/artifacts
- Triggering command: /usr/bin/gh gh run download 12346 --dir test-logs/run-12346 GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env tmatter-with-arrays.md .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD FFiles,SFiles,Sw--show-toplevel 64/pkg/tool/linux_amd64/vet (http block)
https://api.github.com/repos/github/gh-aw/actions/runs/2/artifacts
- Triggering command: /usr/bin/gh gh run download 2 --dir test-logs/run-2 GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env -json .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet (http block)
https://api.github.com/repos/github/gh-aw/actions/runs/3/artifacts
- Triggering command: /usr/bin/gh gh run download 3 --dir test-logs/run-3 GO111MODULE 64/pkg/tool/linu-test.short=true GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linuTest User env -json .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet (http block)
https://api.github.com/repos/github/gh-aw/actions/runs/4/artifacts
- Triggering command: /usr/bin/gh gh run download 4 --dir test-logs/run-4 GO111MODULE 64/pkg/tool/linu-test.short=true GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/[email protected] env -json .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet (http block)
https://api.github.com/repos/github/gh-aw/actions/runs/5/artifacts
- Triggering command: /usr/bin/gh gh run download 5 --dir test-logs/run-5 GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env -json .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet (http block)
https://api.github.com/repos/github/gh-aw/actions/workflows
- Triggering command: /usr/bin/gh gh workflow list --json name,state,path -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
- Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 100 GOMOD GOMODCACHE go ode_�� -json GO111MODULE x_amd64/link GOINSECURE GOMOD GOMODCACHE x_amd64/link (http block)
- Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 6 GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet (http block)
https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.0.0
- Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq .object.sha -json .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env ck '**/*.cjs' '**/*.ts' '**/*.jsremote.origin.url .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linuorigin (http block)
https://api.github.com/repos/nonexistent/repo/actions/runs/12345
- Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion GOINSECURE GOMOD GOMODCACHE x_amd64/compile env g_.a GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet (http block)
https://api.github.com/repos/owner/repo/actions/workflows
- Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
- Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE sh GOINSECURE GOMOD GOMODCACHE go (http block)
- Triggering command: /usr/bin/gh gh workflow list --repo owner/repo --json name,path,state 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env -json .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet (http block)
https://api.github.com/repos/test-owner/test-repo/actions/secrets
- Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
https://api.github.com/user
- Triggering command: /usr/bin/gh gh api user --jq .login re GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
- Triggering command: /usr/bin/gh gh api user --jq .login -json .cfg 64/pkg/tool/linux_amd64/vet en \ PATH="$GOPgit GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env -json .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet (http block)
- Triggering command: /usr/bin/gh gh api user --jq .login -json .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE Ph/9tSyL1twsYAgyQQ9k5eX/1ZABOlD85-x7MLX-NKsq env y-test.md GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

Reference: https://github.com/github/gh-aw/actions/runs/22020319152/job/63628292631#step:7:1

Lint go

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: pelikhan <[email protected]>

Copilot

Pull request overview

This PR fixes Go staticcheck ST1005 linting violations by lowercasing error message prefixes that start with "Docker" to comply with Go's error string conventions, which require error messages to start with lowercase letters unless beginning with proper nouns, acronyms, or exported identifiers.

Changes:

Lowercased "Docker" to "docker" in two error message strings to comply with ST1005

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-14T16:42:01Z

pkg/workflow/docker_validation.go

 	if err != nil {
 		dockerValidationLog.Print("Docker not installed, cannot validate image")
-		return fmt.Errorf("Docker not installed - could not validate container image '%s'. Install Docker or remove container-based tools", image)
+		return fmt.Errorf("docker not installed - could not validate container image '%s'. Install Docker or remove container-based tools", image)


The error message now starts with lowercase 'docker' per ST1005, but later in the same message 'Install Docker' uses uppercase 'Docker'. For consistency with the linting fix and Go conventions, consider lowercasing this reference as well to 'install docker'.

Suggested change

return fmt.Errorf("docker not installed - could not validate container image '%s'. Install Docker or remove container-based tools", image)

return fmt.Errorf("docker not installed - could not validate container image '%s'. install docker or remove container-based tools", image)

Copilot · 2026-02-14T16:42:02Z

pkg/workflow/docker_validation.go

 	if !isDockerDaemonRunning() {
 		dockerValidationLog.Print("Docker daemon not running, cannot validate image")
-		return fmt.Errorf("Docker daemon not running - could not validate container image '%s'. Start Docker Desktop or remove container-based tools", image)
+		return fmt.Errorf("docker daemon not running - could not validate container image '%s'. Start Docker Desktop or remove container-based tools", image)


The error message now starts with lowercase 'docker' per ST1005, but later references 'Start Docker Desktop' with uppercase. While 'Docker Desktop' is a product name, for consistency with the linting fix, consider using lowercase for the verb: 'start docker desktop'.

Suggested change

return fmt.Errorf("docker daemon not running - could not validate container image '%s'. Start Docker Desktop or remove container-based tools", image)

return fmt.Errorf("docker daemon not running - could not validate container image '%s'. start docker desktop or remove container-based tools", image)

Initial plan

37c6c5a

Copilot AI assigned Copilot and pelikhan Feb 14, 2026

Copilot started work on behalf of pelikhan February 14, 2026 16:30 View session

Fix Go linting errors: lowercase error string messages

f332d30

Co-authored-by: pelikhan <[email protected]>

Copilot AI changed the title ~~[WIP] Add linting for Go code~~ Fix ST1005 linting errors in docker validation error messages Feb 14, 2026

Copilot AI requested a review from pelikhan February 14, 2026 16:38

Copilot finished work on behalf of pelikhan February 14, 2026 16:38

pelikhan approved these changes Feb 14, 2026

View reviewed changes

pelikhan marked this pull request as ready for review February 14, 2026 16:39

Copilot AI review requested due to automatic review settings February 14, 2026 16:39

pelikhan merged commit f7fbd65 into main Feb 14, 2026

pelikhan deleted the copilot/lint-go-code-yet-again branch February 14, 2026 16:39

Copilot started reviewing on behalf of pelikhan February 14, 2026 16:40 View session

Copilot AI reviewed Feb 14, 2026

View reviewed changes

This was referenced Feb 14, 2026

Smoke Test: Copilot - 22021153414 #15718

Open

Smoke Test: Claude - 22021153424 #15720

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix ST1005 linting errors in docker validation error messages#15710

Fix ST1005 linting errors in docker validation error messages#15710
pelikhan merged 2 commits intomainfrom
copilot/lint-go-code-yet-again

Copilot AI commented Feb 14, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 14, 2026

Uh oh!

Copilot AI Feb 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	return fmt.Errorf("docker not installed - could not validate container image '%s'. Install Docker or remove container-based tools", image)
	return fmt.Errorf("docker not installed - could not validate container image '%s'. install docker or remove container-based tools", image)

	return fmt.Errorf("docker daemon not running - could not validate container image '%s'. Start Docker Desktop or remove container-based tools", image)
	return fmt.Errorf("docker daemon not running - could not validate container image '%s'. start docker desktop or remove container-based tools", image)

Conversation

Copilot AI commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Feb 14, 2026 •

edited

Loading