Skip to content

Close #867: Test samples already exist in repository#880

Merged
lpcox merged 1 commit intomainfrom
claude/add-typescript-javascript-test-samples
Feb 11, 2026
Merged

Close #867: Test samples already exist in repository#880
lpcox merged 1 commit intomainfrom
claude/add-typescript-javascript-test-samples

Conversation

@Claude
Copy link
Contributor

@Claude Claude AI commented Feb 11, 2026

Issue #867 reports missing TypeScript/JavaScript and Python test samples for language support testing. These samples were added in PR #879 (commit 97784a4) on Feb 10, 2026 - one day after the issue was created. The issue remained open erroneously.

Verification

JavaScript/TypeScript (test/serena-mcp-tests/samples/js_project/):

  • calculator.js - Calculator class with methods (add, multiply, greet)
  • utils.js - formatNumber utility function
  • package.json - Project metadata for language server detection

Python (test/serena-mcp-tests/samples/python_project/):

  • calculator.py - Calculator class with type hints and methods
  • utils.py - format_number utility function

All files match specifications in .github/agentics/language-support-tester.md. No code changes required.

Original prompt

This section details on the original issue you should resolve

<issue_title>[language-support] TypeScript/JavaScript and Python test samples missing for language support testing</issue_title>
<issue_description>## Summary

The language support tester workflow cannot fully test TypeScript/JavaScript and Python support because the required test sample directories do not exist in the repository.

What Works

Go Language Support - Successfully tested and verified:

  • find_symbol correctly identifies functions in main.go and other Go files
  • get_symbols_overview returns accurate symbol listings for Go files
  • find_referencing_symbols successfully traces references across Go files
  • Language server responds correctly to all queries

What's Missing

TypeScript/JavaScript Test Samples

  • Expected location: /workspace/test/serena-mcp-tests/samples/js_project/
  • Status: Directory does not exist
  • Impact: Cannot test TypeScript/JavaScript language server functionality

Python Test Samples

  • Expected location: /workspace/test/serena-mcp-tests/samples/python_project/
  • Status: Directory does not exist
  • Impact: Cannot test Python language server functionality

Steps to Reproduce

  1. Run the language-support-tester workflow
  2. Attempt to activate TypeScript/JavaScript project at specified path
  3. Observe that the path does not exist

Requested Fix

Add test sample directories with minimal but sufficient code to test language server functionality:

JavaScript/TypeScript samples (test/serena-mcp-tests/samples/js_project/):

  • Simple function definitions
  • Class with methods
  • Import/export statements
  • package.json for project detection

Python samples (test/serena-mcp-tests/samples/python_project/):

  • Simple function definitions (e.g., format_number)
  • Class with methods (e.g., Calculator class with add method)
  • Import statements
  • Sufficient for testing find_symbol, get_symbols_overview, and find_referencing_symbols

Testing Guidelines Reference

From .github/agentics/language-support-tester.md:

  • TypeScript/JavaScript: Test samples at /workspace/test/serena-mcp-tests/samples/js_project/
  • Python: Test samples at /workspace/test/serena-mcp-tests/samples/python_project/ with calculator.py, utils.py containing Calculator class, add method, format_number function

Workaround

Currently, only Go language support can be tested using the existing Go source files in the repository root and would-be internal/ directory.

AI generated by Language Support Tester

  • expires on Feb 16, 2026, 10:53 AM UTC

Comments on the Issue (you are @claude[agent] in this section)

@Claude Claude AI assigned Claude and lpcox Feb 11, 2026
@Claude Claude AI changed the title [WIP] Add TypeScript/JavaScript and Python test samples for language support Close #867: Test samples already exist in repository Feb 11, 2026
@Claude Claude AI requested a review from lpcox February 11, 2026 00:31
@lpcox lpcox marked this pull request as ready for review February 11, 2026 00:32
Copilot AI review requested due to automatic review settings February 11, 2026 00:32
@lpcox lpcox merged commit 7f265c3 into main Feb 11, 2026
3 checks passed
@lpcox lpcox deleted the claude/add-typescript-javascript-test-samples branch February 11, 2026 00:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[language-support] TypeScript/JavaScript and Python test samples missing for language support testing

2 participants