[test-improver] Improve tests for httputil package

[github-actions]

File Analyzed

• Test File: internal/httputil/httputil_test.go
• Package: internal/httputil
• Lines Added: +37

Improvements Made

1. Increased Coverage

Added TestComputeRetryAfter to cover the previously untested ComputeRetryAfter function in github_http.go, which was the sole coverage gap in the package.

• ✅ Added test: zero time → returns default 60s
• ✅ Added test: time in the past → returns default 60s (the secs < 1 branch)
• ✅ Added test: future time → returns delay with 1s safety buffer (assert.InDelta used to tolerate scheduling jitter)
• ✅ Added test: far future (2h) → clamped to 3600s maximum
• ✅ Added test: just above max (3601s) → still clamped to 3600s

Previous Coverage: 86.8%
New Coverage: 100.0%
Improvement: +13.2%

2. Better Testing Patterns

• Uses t.Parallel() for all subtests consistent with existing test style
• Uses assert.InDelta for the timing-sensitive case to avoid flakiness from scheduling jitter
• Table-free structure matches the function's non-tabular branching logic

Test Execution

All tests pass:

ok  github.com/github/gh-aw-mcpg/internal/httputil  0.008s  coverage: 100.0% of statements

Why These Changes?

ComputeRetryAfter computes the Retry-After delay for rate-limited GitHub API responses. It has four distinct code branches (zero time, past time, within-range future, and over-max future) but had zero test coverage. The function is called when GitHub returns a X-RateLimit-Reset header, making it important for correct retry behaviour.

---

Generated by Test Improver Workflow
Focuses on better patterns, increased coverage, and more stable tests

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• index.crates.io

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "index.crates.io"

See Network Configuration for more information.

Generated by Test Improver · 611.1 AIC · ⊞ 29.5K · ◷