Set status annotation when AzureCluster reconciler completes#356
Open
Set status annotation when AzureCluster reconciler completes#356
Conversation
fiunchinho
reviewed
Apr 7, 2026
Member
fiunchinho
left a comment
fiunchinho
left a comment
There was a problem hiding this comment.
This approach works for me, but I was just wondering: could it be possible to do the same but setting a Condition instead? To me it makes more sense to have this information in the status, rather than in an annotation. But I think it's fine using an annotation, it's just a though.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/giantswarm/giantswarm/issues/35240. Defining an easy signal to know when the reconciler is done.
Tested on
glean.