Skip to content

libghostty-vt: preserve shell prompts on resize by default#12653

Open
noib3 wants to merge 1 commit into
ghostty-org:mainfrom
noib3:libghostty-disable-shell-redraws
Open

libghostty-vt: preserve shell prompts on resize by default#12653
noib3 wants to merge 1 commit into
ghostty-org:mainfrom
noib3:libghostty-disable-shell-redraws

Conversation

@noib3
Copy link
Copy Markdown
Contributor

@noib3 noib3 commented May 11, 2026

This PR makes libghostty-vt preserve shell prompts across resize unless the shell explicitly opts into prompt clearing/redraw with redraw=1.

This PR makes libghostty-vt preserve shell prompts across resize unless
the shell explicitly opts into prompt clearing/redraw with `redraw=1`.
@noib3 noib3 requested a review from a team as a code owner May 11, 2026 06:49
Copy link
Copy Markdown
Contributor

@mitchellh mitchellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darn, I can't remember the history here of why this is even defaulted to true. It seems like it might be safe to default this to false in all of Ghostty until we see any semantic prompt marker. I want to think about that for a bit instead of the targeted fix here in libghostty-vt.

@jparise
Copy link
Copy Markdown
Contributor

jparise commented May 13, 2026

Darn, I can't remember the history here of why this is even defaulted to true. It seems like it might be safe to default this to false in all of Ghostty until we see any semantic prompt marker. I want to think about that for a bit instead of the targeted fix here in libghostty-vt.

Given that ;redraw is a Kitty invention (not in OSC 133 itself) to opt'ing in to shell redraws, I agree it makes sense to default this to false in the entire runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants