RFC: Screenshot support by reading render surface and writing to file(s)#12056
Closed
justonia wants to merge 1 commit into
Closed
RFC: Screenshot support by reading render surface and writing to file(s)#12056justonia wants to merge 1 commit into
justonia wants to merge 1 commit into
Conversation
Member
|
We should open a discussion for this first, I remember seeing a similar one |
Author
|
Was this the PR you're thinking of? #11601 |
Author
|
@bo2themax Created a discussion: #12057 |
Contributor
|
Just so you know: opening RFC PRs is almost always the wrong thing to do in the Ghostty repository; per
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project I'm working on has the need to automate screenshot collection. I wanted to socialize interest in how this might be supported in Ghostty.
This RFC PR implements screenshot support in the most straightforward way:
ghostty_surface_screenshot(string path).ghostty_surface_screenshot.I considered going the route of a callback-based approach:
But, the file-based approach was simpler to prototype and I wanted to gauge interest in this functionality being a part of Ghostty at all before taking this further.