GTK: Improve Split Close Behavior#11173
Open
cmwetherell wants to merge 4 commits into
Open
Conversation
Add a "Close Split" option to the split submenu in the right-click context menu, allowing users to close the focused split pane directly from the context menu. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Rename internal action and function from close-pane/actionClosePane to close-split/actionCloseSplit for consistency with the UI label. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
You'll need to regenerate the translations - run |
pluiedev
approved these changes
Mar 5, 2026
Member
pluiedev
left a comment
pluiedev
left a comment
There was a problem hiding this comment.
Diff LGTM sans jcollie's comment on regenerating translation strings. This will definitely not make it in 1.3, though, since new strings are introduced - will merge once 1.3 is released and branched off
Author
done! |
cmwetherell
changed the title
Member
pluiedev
approved these changes
Mar 17, 2026
Member
pluiedev
left a comment
pluiedev
left a comment
There was a problem hiding this comment.
LGTM pending merge conflicts
# Conflicts: # po/hu.po # po/id.po
Author
|
Anything needed from me before merge? Should consider merging the macOS PR at the same time as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reference discussion: #10982