macOS: refine new-window behaviors#11161
Open
bo2themax wants to merge 5 commits into
Open
Conversation
bo2themax
changed the title
bo2themax
force-pushed
the
fix-9310
branch
3 times, most recently
from
c611f0c to
a0e918b
Compare
Contributor
|
Too many changes, going to push to 1.4! |
mitchellh
added a commit
that referenced
this pull request
Mar 12, 2026
Added test case for cascading **without moving previous window**, #11161 will follow up for more accurate cascading after this. Fixed window cascading after last pr, now we should perform cascading **after** showing the window.
bo2themax
force-pushed
the
fix-9310
branch
2 times, most recently
from
2e46a9a to
8558641
Compare
bo2themax
force-pushed
the
fix-9310
branch
2 times, most recently
from
84b6720 to
2146d5e
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #9310, rc is that we're saving
lastCascadePoint, but not updating it when a window moves; it only updates when a new window opens.In fact, cascading only makes sense when there's an existing window in this screen; when there is no window in this screen, we only need to restore the last frame we saved.
The first two commits solve the
new-windowbehaviors mentioned in #9310, and the third commit changesLastWindowPositionto save and restore frame information by screen id, and added some tests for itLast commit skips saving the native full-screen window frame, which makes sense to me after reading the comment here.
2026-03-04.15-07-01.mov
AI Disclosure
AI proofread my comments.