Conversation
This requires staging flag for now
chrmod
left a comment
chrmod
left a comment
There was a problem hiding this comment.
what this should react to env_experimental?
We need to eliminate the calls to hybridjs and import.meta.glob.
…extension into preprocessors
|
@smalluban I wonder if proceeding in that direction is the simplest. Please confirm that we put loader to every module that loading the module including "hybrid", "import.meta.glob", or use of absolute path: "/...". We have so many places to patch even including build step: scripts/download-dnr-rulesets.js (requires utils/dnr.js). We can just create another utils/env.js and isolate the env or put loader to everywhere. Putting loader and patching the source code on the way makes us to consider source-mapping in the future as well. |
|
@seia-soto, please update the branch and set the PR as "ready for review". |
|
@seia-soto This is a good question from @chrmod
Have you considered that? |
|
@smalluban I think it's fine since we regenerate the list of filters to be disabled on every configuration update. |
3 participants
fixes #3057