feat: support scriptletGlobals.warOrigin#2716
Merged
philipp-classen merged 13 commits intoghostery:mainfrom Sep 26, 2025
Merged
feat: support scriptletGlobals.warOrigin#2716philipp-classen merged 13 commits intoghostery:mainfrom
scriptletGlobals.warOrigin#2716philipp-classen merged 13 commits intoghostery:mainfrom
Conversation
seia-soto
requested review from
chrmod and
smalluban
and removed request for
smalluban
1 task
seia-soto
changed the title
scriptletGlobals.warOriginscriptletGlobals.warOrigin
Member
Author
|
Updated the lockfile, it includes: refs ghostery/scriptlets#27 |
Calling `chrome.runtime.getURL` with non-existing resource will result in real extension ID leakage.
…to/ghostery-extension into support-scriptletglobals
`readystatechange` might be called twice.
Member
Author
|
Corresponding test added and fixed quirks; ready for the final review. |
Collaborator
|
#2736 should fix the issue with creating a package. |
smalluban
reviewed
Sep 25, 2025
smalluban
approved these changes
Sep 26, 2025
philipp-classen
approved these changes
Sep 26, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes ghostery/broken-page-reports#1718
depends on ghostery/scriptlets#26
This supports the injection of
scriptletGlobalsfor scriptlets depending on redirect resources of the extension packages. See https://github.com/ghostery/scriptlets/blob/main/ubo.js#L19175-L19192 for the reference and checkghostery/scriptletrepository to align the changes.